You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rb...@apache.org on 2011/04/15 22:06:54 UTC
svn commit: r1092797 - /httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
Author: rbowen
Date: Fri Apr 15 20:06:53 2011
New Revision: 1092797
URL: http://svn.apache.org/viewvc?rev=1092797&view=rev
Log:
Whether it's intentional or not, the hostname/domainname argument to the
RewriteRule CO flag is in fact required. Cookies are not set without it.
(via Matthew Sporleder)
Modified:
httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
Modified: httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml?rev=1092797&r1=1092796&r2=1092797&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml (original)
+++ httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml Fri Apr 15 20:06:53 2011
@@ -1100,7 +1100,7 @@ cannot use <code>$N</code> in the substi
<tr>
<td>cookie|CO=<em>NAME</em>:<em>VAL</em></td>
<td>Sets a cookie in the client browser. Full syntax is:
- CO=<em>NAME</em>:<em>VAL</em>[:<em>domain</em>[:<em>lifetime</em>[:<em>path</em>[:<em>secure</em>[:<em>httponly</em>]]]]] <em><a href="../rewrite/flags.html#flag_co">details ...</a></em>
+ CO=<em>NAME</em>:<em>VAL</em>:<em>domain</em>[:<em>lifetime</em>[:<em>path</em>[:<em>secure</em>[:<em>httponly</em>]]]] <em><a href="../rewrite/flags.html#flag_co">details ...</a></em>
</td>
</tr>
<tr>
Re: svn commit: r1092797 - /httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
Posted by Rich Bowen <rb...@rcbowen.com>.
I've fixed this in the docs, but wanted to verify that the actual behavior is in fact the desired behavior. The docs state (stated until today) that the domain argument to the CO RewriteRule flag would default to the current domain. This is not the case. Omitting the domain argument results in:
74.131.224.250 - - [15/Apr/2011:20:01:06 +0000] [embowen.com/sid#7ff55cfc54f8][rid#7ff55d254168/subreq] (1) pass through /index.php
(Test case: RewriteRule ^ - [CO=foo:bar])
whereas with the domain, it results in:
74.131.224.250 - - [15/Apr/2011:20:01:33 +0000] [embowen.com/sid#7f02acd994f8][rid#7f02ad0180e8/initial] (5) setting cookie 'foo=bar; path=/; domain=embowen.com'
74.131.224.250 - - [15/Apr/2011:20:01:33 +0000] [embowen.com/sid#7f02acd994f8][rid#7f02ad0180e8/initial] (1) pass through /index.php
(Test case: RewriteRule ^ - [CO=foo:bar:embowen.com]
Granted, it seems to be a good idea to always set the domain, and in fact I had never encountered this "bug" before because I always do set the domain.
On Apr 15, 2011, at 4:06 PM, rbowen@apache.org wrote:
> Author: rbowen
> Date: Fri Apr 15 20:06:53 2011
> New Revision: 1092797
>
> URL: http://svn.apache.org/viewvc?rev=1092797&view=rev
> Log:
> Whether it's intentional or not, the hostname/domainname argument to the
> RewriteRule CO flag is in fact required. Cookies are not set without it.
> (via Matthew Sporleder)
>
> Modified:
> httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
>
> Modified: httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml?rev=1092797&r1=1092796&r2=1092797&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml (original)
> +++ httpd/httpd/trunk/docs/manual/mod/mod_rewrite.xml Fri Apr 15 20:06:53 2011
> @@ -1100,7 +1100,7 @@ cannot use <code>$N</code> in the substi
> <tr>
> <td>cookie|CO=<em>NAME</em>:<em>VAL</em></td>
> <td>Sets a cookie in the client browser. Full syntax is:
> - CO=<em>NAME</em>:<em>VAL</em>[:<em>domain</em>[:<em>lifetime</em>[:<em>path</em>[:<em>secure</em>[:<em>httponly</em>]]]]] <em><a href="../rewrite/flags.html#flag_co">details ...</a></em>
> + CO=<em>NAME</em>:<em>VAL</em>:<em>domain</em>[:<em>lifetime</em>[:<em>path</em>[:<em>secure</em>[:<em>httponly</em>]]]] <em><a href="../rewrite/flags.html#flag_co">details ...</a></em>
> </td>
> </tr>
> <tr>
>
>
--
Rich Bowen
rbowen@rcbowen.com
rbowen@apache.org