You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/11 08:25:18 UTC

[GitHub] [calcite] dawidwys opened a new pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

dawidwys opened a new pull request #2254:
URL: https://github.com/apache/calcite/pull/2254


   The PR fixes the list of returned operands in `SqlMatchRecognize`. Without the change e.g. `SqlShuttle` cannot be used with `MATCH_RECOGNIZE` clause.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] dawidwys edited a comment on pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #2254:
URL: https://github.com/apache/calcite/pull/2254#issuecomment-725346513


   Sorry for not abiding the guide. I updated the commit message accordingly to your suggestion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2254:
URL: https://github.com/apache/calcite/pull/2254#issuecomment-725341151


   LGTM
   
   Thanks for the PR @dawidwys . Some minor details to correct the commit message (as per https://calcite.apache.org/develop/#contributing):
   - The commit message should describe the issue, and should not begin with "Fix ...". IMHO the Jira title ("SqlMatchRecognize returns wrong operand list") would be a more adequate commit message.
   - The commit message should end with your name & last name in parentheses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] dawidwys edited a comment on pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #2254:
URL: https://github.com/apache/calcite/pull/2254#issuecomment-725346513


   Sorry for not abiding by the guide. I updated the commit message according to your suggestion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada merged pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
rubenada merged pull request #2254:
URL: https://github.com/apache/calcite/pull/2254


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] dawidwys edited a comment on pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #2254:
URL: https://github.com/apache/calcite/pull/2254#issuecomment-725346513


   Sorry for not abiding by the guide. I updated the commit message accordingly to your suggestion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] dawidwys commented on pull request #2254: [CALCITE-4390] Fix SqlMatchRecognize operand list

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #2254:
URL: https://github.com/apache/calcite/pull/2254#issuecomment-725346513


   Sorry for not abiding the guide. I updated the commit message according to the rules.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org