[GitHub] [superset] john-bodley commented on a diff in pull request #23674: chore(presto): Expose schema and indexes to _partition_query method

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #23674:
URL: https://github.com/apache/superset/pull/23674#discussion_r1165321738


##########
superset/db_engine_specs/presto.py:
##########
@@ -423,24 +423,27 @@ def get_function_names(cls, database: Database) -> List[str]:
         return database.get_df("SHOW FUNCTIONS")["Function"].tolist()
 
     @classmethod
-    def _partition_query(  # pylint: disable=too-many-arguments,too-many-locals
+    def _partition_query(  # pylint: disable=too-many-arguments,too-many-locals,unused-argument
         cls,
+        schema: Optional[str],

Review Comment:
   Given this is a private method, changing the order of the function arguments is deemed non-breaking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org