[jira] [Commented] (FLINK-15171) Performance regression in serialisation benchmarks

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006825#comment-17006825 ] 

Chesnay Schepler commented on FLINK-15171:
------------------------------------------

[~pnowojski] Looks like the regression got mostly fixed. For tuples/row/pojo we appear to be getting better numbers than before; although for heavy strings it looks like we took a small performance hit.

> Performance regression in serialisation benchmarks
> --------------------------------------------------
>
>                 Key: FLINK-15171
>                 URL: https://issues.apache.org/jira/browse/FLINK-15171
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Type Serialization System, Benchmarks
>    Affects Versions: 1.10.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>         Attachments: dec05.svg, dec11.svg
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is quite significant performance regression in serialisation benchmarks in the commit range 2ecf7ca..9320f34 (which includes FLINK-14346).
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerTuple&env=2
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerRow&env=2
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerPojo&env=2
> it coincides with the performance improvement for heavy strings
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerHeavyString&env=2
> it might be caused by some accidental change in the benchmarking code (changing parallelism in one benchmarks is carried on to the next one?) or in the code itself.
> CC [~rgrebennikov] [~AHeise]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)