You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/17 02:07:48 UTC
[GitHub] [spark] maropu opened a new pull request #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
maropu opened a new pull request #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR intends to update the `DataFrameWriter.bucketBy` comment for clearly describing that the bucketBy scheme follows a Spark "specific" one.
I saw the questions about the current bucketing compatibility with Hive in [SPARK-31162](https://issues.apache.org/jira/browse/SPARK-31162?focusedCommentId=17060408&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17060408) and [SPARK-17495](https://issues.apache.org/jira/browse/SPARK-17495?focusedCommentId=17059847&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17059847) from users and IMHO the comment is a bit confusing to users about the compatibility
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make users understood smoothly.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27930: [SQL][MINOR] Update the
DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886622
**[Test build #119910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119910/testReport)** for PR 27930 at commit [`a1bfa96`](https://github.com/apache/spark/commit/a1bfa9623ab4a5162709bf55d56f055300fd34f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27930: [SQL][MINOR] Update the
DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599910664
**[Test build #119910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119910/testReport)** for PR 27930 at commit [`a1bfa96`](https://github.com/apache/spark/commit/a1bfa9623ab4a5162709bf55d56f055300fd34f2).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599906930
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27930: [SQL][MINOR] Update the
DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599906140
**[Test build #119902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119902/testReport)** for PR 27930 at commit [`022bb72`](https://github.com/apache/spark/commit/022bb72483024e6238ca6c162841ad4d4a591c7e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#discussion_r393452207
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -197,8 +197,8 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
}
/**
- * Buckets the output by the given columns. If specified, the output is laid out on the file
- * system similar to Hive's bucketing scheme.
+ * Buckets the output by the given columns. Note that the output follows a Spark SQL specific
+ * bucketing scheme based on the Hive scheme.
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599906930
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27930: [MINOR][SQL]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27930: [MINOR][SQL] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599910787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119910/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24636/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#discussion_r393405863
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -197,8 +197,8 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
}
/**
- * Buckets the output by the given columns. If specified, the output is laid out on the file
- * system similar to Hive's bucketing scheme.
+ * Buckets the output by the given columns. Note that the output follows a Spark SQL specific
+ * bucketing scheme based on the Hive scheme.
Review comment:
minor though, WDYT this update? @cloud-fan @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#discussion_r393440110
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -197,8 +197,8 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
}
/**
- * Buckets the output by the given columns. If specified, the output is laid out on the file
- * system similar to Hive's bucketing scheme.
+ * Buckets the output by the given columns. Note that the output follows a Spark SQL specific
+ * bucketing scheme based on the Hive scheme.
Review comment:
I feel the original one is clear enough as it says "similar to". Maybe we can add one more sentence: `..., but with a different bucket hash function and is not compatible with Hive's bucketing.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841766
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599910782
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841766
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599925806
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24628/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24636/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599910787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119910/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27930: [MINOR][SQL] Update the
DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27930: [MINOR][SQL] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599930114
Thanks, guys!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599910782
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27930: [SQL][MINOR] Update the
DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841421
**[Test build #119902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119902/testReport)** for PR 27930 at commit [`022bb72`](https://github.com/apache/spark/commit/022bb72483024e6238ca6c162841ad4d4a591c7e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841421
**[Test build #119902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119902/testReport)** for PR 27930 at commit [`022bb72`](https://github.com/apache/spark/commit/022bb72483024e6238ca6c162841ad4d4a591c7e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599841771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24628/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599906935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119902/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599906935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119902/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27930:
[SQL][MINOR] Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#discussion_r393452684
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -197,8 +197,8 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
}
/**
- * Buckets the output by the given columns. If specified, the output is laid out on the file
- * system similar to Hive's bucketing scheme.
+ * Buckets the output by the given columns. Note that the output follows a Spark SQL specific
+ * bucketing scheme based on the Hive scheme.
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27930: [SQL][MINOR]
Update the DataFrameWriter.bucketBy comment
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27930: [SQL][MINOR] Update the DataFrameWriter.bucketBy comment
URL: https://github.com/apache/spark/pull/27930#issuecomment-599886622
**[Test build #119910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119910/testReport)** for PR 27930 at commit [`a1bfa96`](https://github.com/apache/spark/commit/a1bfa9623ab4a5162709bf55d56f055300fd34f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org