You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ttulka <gi...@git.apache.org> on 2018/11/07 10:53:33 UTC
[GitHub] commons-collections pull request #56: The put method should return the previ...
GitHub user ttulka opened a pull request:
https://github.com/apache/commons-collections/pull/56
The put method should return the previous record only if not expired
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ttulka/commons-collections master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-collections/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit e3abf938fe8b137d0c6e2927d6d0923f9a6d7321
Author: Tomas Tulka <to...@...>
Date: 2018-11-07T10:51:45Z
the put method should return the previous record only if not expired
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections pull request #56: The put method should return the previ...
Posted by ttulka <gi...@git.apache.org>.
Github user ttulka closed the pull request at:
https://github.com/apache/commons-collections/pull/56
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #56: The put method should return the previous rec...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/56
In git master. Please verify and close.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #56: The put method should return the previous rec...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/56
Hi @ttulka ,
Do you have a unit test that demonstrates the pronlem?
Gary
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #56: The put method should return the previous rec...
Posted by ttulka <gi...@git.apache.org>.
Github user ttulka commented on the issue:
https://github.com/apache/commons-collections/pull/56
Hi @garydgregory
Yes, in the commit there is a test `testPut()` in the class `src/test/java/org/apache/commons/collections4/map/PassiveExpiringMapTest.java`
Cheers, Tomas
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org