You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/04/15 10:30:49 UTC
[jira] Created: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Archiving and Purging of parity files should handle globbed policies
--------------------------------------------------------------------
Key: MAPREDUCE-1705
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/raid
Affects Versions: 0.22.0
Reporter: Rodrigo Schmidt
Fix For: 0.22.0
Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861111#action_12861111 ]
dhruba borthakur commented on MAPREDUCE-1705:
---------------------------------------------
I agree, i reran the tests now and it works as you explained. I will commit this patch.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated MAPREDUCE-1705:
----------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I just committed this. Thanks Rodrigo!
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated MAPREDUCE-1705:
---------------------------------------
Attachment: MAPREDUCE-1705.0.patch
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated MAPREDUCE-1705:
---------------------------------------
Status: Patch Available (was: Open)
First patch.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861101#action_12861101 ]
Rodrigo Schmidt commented on MAPREDUCE-1705:
--------------------------------------------
Dhruba, I just double checked. The new unit tests (TestRaidPurge and TestRaidHar) block if the patch is not applied to RaidNode.java.
They pass if they are not changed, and they also pass if the whole patch is applied. Maybe you didn't apply the changes to the unit tests, or you applied the whole patch when you tested.
As for the Hadoop QA output, the two core tests that failed are unrelated to Raid.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861129#action_12861129 ]
Rodrigo Schmidt commented on MAPREDUCE-1705:
--------------------------------------------
Great! Thanks!
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt reassigned MAPREDUCE-1705:
------------------------------------------
Assignee: Rodrigo Schmidt
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860863#action_12860863 ]
dhruba borthakur commented on MAPREDUCE-1705:
---------------------------------------------
Code looks good. I tried running the test case without the patch applied and the test case succeeded. Let me re-try.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860937#action_12860937 ]
Hadoop QA commented on MAPREDUCE-1705:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442833/MAPREDUCE-1705.0.patch
against trunk revision 937924.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/139/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/139/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/139/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/139/console
This message is automatically generated.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1705) Archiving and Purging of parity
files should handle globbed policies
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861112#action_12861112 ]
dhruba borthakur commented on MAPREDUCE-1705:
---------------------------------------------
The two failed tests are org.apache.hadoop.mapred.TestBadRecords.testBadMapRed org.apache.hadoop.mapreduce.TestJobACLs.testACLS asnd is not related to RAID.
> Archiving and Purging of parity files should handle globbed policies
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-1705
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1705
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/raid
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1705.0.patch
>
>
> Archiving (har) and purging of parity files don't work in policies whose source is a globbed path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.