[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11084: [DUBBO-11047][issue]Remove direct dependency of protobuf-java

[GitBox <gi...@apache.org>]

AlbumenJ commented on code in PR #11084:
URL: https://github.com/apache/dubbo/pull/11084#discussion_r1045448705


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/service/TriBuiltinService.java:
##########
@@ -67,6 +74,11 @@ public void init() {
         }
     }
 
+    public boolean enable(){
+        return config.getBoolean(TRI_BUILTIN_SERVICE_INIT, false);

Review Comment:
   Can we check if users has add the `protobuf-java` dependency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org