You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/26 05:18:41 UTC
[GitHub] [dolphinscheduler] chengshiwen opened a new pull request #5700: [Fix-5699][UI] Fix update user error in user information
chengshiwen opened a new pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700
## Purpose of the pull request
*[Fix-5699][UI] Fix update user error in user information*
This fixes #5699, and fixes the problem introduced by #5627
## Brief change log
- *Fix update user error in user information*
- *Sync user info by `this.setUserInfo(param)`*
## Verify this pull request
This change added tests and can be verified as follows:
- *Manually verified the change by testing locally.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kyoty edited a comment on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
kyoty edited a comment on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872367658
@chengshiwen @CalvinKirs @myangle1120 Sorry to bother you guys.
+ this PR is supposed to solve the problem introduced in #5627, sorry I'm not sure What problem was introduced in #5627?
I have tried to reproduce the screenshot menshoned in Issue#5699, but I can't reproduce it, it's a little strange. Can you tell me what problem was introduced @chengshiwen ,I want to know what had happend so I can avoid similar mistakes in the future。
+ **In addition, I personally think that the current PR introduces a new problem: if we create a new user using admin, such as test, after successfully creating, the current logged-in user displayed in the top right corner of the page will be updated to the current newly created user,** you can see my screenshot based on the latest code of dev:
1. try to add a new user named test, now the username of current user is admin.
2. after the user has been created, the username of current user changes from admin to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-868950720
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5700](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f9672b) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/b31ba7e18b89885c37c2129bf9b4816001f09e51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b31ba7e) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #5700 +/- ##
=========================================
Coverage 45.36% 45.36%
+ Complexity 3688 3687 -1
=========================================
Files 607 607
Lines 24855 24855
Branches 2825 2825
=========================================
Hits 11275 11275
+ Misses 12498 12496 -2
- Partials 1082 1084 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/5700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.35% <0.00%> (-1.70%)` | :arrow_down: |
| [...olphinscheduler/plugin/alert/email/MailSender.java](https://codecov.io/gh/apache/dolphinscheduler/pull/5700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvTWFpbFNlbmRlci5qYXZh) | `72.91% <0.00%> (-1.39%)` | :arrow_down: |
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/5700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `68.05% <0.00%> (+4.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b31ba7e...7f9672b](https://codecov.io/gh/apache/dolphinscheduler/pull/5700?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-869865581
please take a look,thx @zhuangchong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] chengshiwen edited a comment on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872679926
@kyoty @CalvinKirs Sorry, introducing the second problem is my mistake, and I have submitted a repaired pr #5735
For the 1st problem, the following lines will cause a tenant named `0` to appear, which is not right. So the solution of the previous pr #5276 needs to be reimplemented
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L297
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L316
A tenant named `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-869447511
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5700&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5700&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5700&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5700&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-869865581
please take a look,thx @zhuangchong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs merged pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kyoty commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872681835
@chengshiwen Thank you for your repair., I will pay more attention to the enhance the test when I submit PR in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs merged pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kyoty commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872367658
@chengshiwen @CalvinKirs @myangle1120 Sorry to bother you guys.
+ this PR is supposed to solve the problem introduced in #5627, sorry I'm not sure What problem was introduced in #5627?
I have tried to reproduce the screenshot menshoned in Issue#5699, but I can't reproduce it, it's a little strange.
+ **In addition, I personally think that the current PR introduces a new problem: if we create a new user using admin, such as test, after successfully creating, the current logged-in user displayed in the top right corner of the page will be updated to the current newly created user,** you can see my screenshot based on the latest code of dev:
1. try to add a new user named test, now the username of current user is admin.
2. after the user has been created, the username of current user changes from admin to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] chengshiwen commented on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872679926
@kyoty @CalvinKirs Sorry, introducing the second problem is my mistake, and I have submitted a repaired pr #5735
For the 1st problem, the following lines will cause a tenant named `0` to appear, which is not right
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L297
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L316
A tenant named `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kyoty edited a comment on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
kyoty edited a comment on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872681835
@chengshiwen Thank you for your repair., I will pay more attention to enhance the test when I submit PR in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] chengshiwen edited a comment on pull request #5700: [Fix-5699][UI] Fix update user error in user information
Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #5700:
URL: https://github.com/apache/dolphinscheduler/pull/5700#issuecomment-872679926
@kyoty @CalvinKirs Sorry, introducing the second problem is my mistake, and I have submitted a repaired pr #5735
For the 1st problem, the following lines will cause a tenant named `0` to appear, which is not right. So the solution of the previous pr #5627 needs to be reimplemented
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L297
https://github.com/apache/dolphinscheduler/blob/0a5670f1958bfca56f84e42c1e11bb3150abcb4b/dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue#L316
A tenant named `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org