You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/23 04:50:35 UTC

[GitHub] [incubator-kyuubi] zwangsheng commented on a change in pull request #974: [KYUUBI #962] Support multiple engines under USER share level

zwangsheng commented on a change in pull request #974:
URL: https://github.com/apache/incubator-kyuubi/pull/974#discussion_r693652318



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -108,4 +109,19 @@ object HighAvailabilityConf {
     .version("1.4.0")
     .stringConf
     .createOptional
+
+  val HA_ZK_ENGINE_POOL_SIZE: ConfigEntry[Int] =
+    buildConf("ha.engine.pool.size")
+      .doc("Maximum number of engines when using USER share level.")
+      .version("1.4.0")
+      .intConf
+      .createWithDefault(1)

Review comment:
       How about use `checkValues` to make sure this configuration remains positive?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org