You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/31 14:47:32 UTC

[I] Edits to amber's LICENSE-binary and NOTICE-binary files skip the CI checks that validate them [texera]

aglinxinyuan opened a new issue, #8294:
URL: https://github.com/apache/texera/issues/8294

   ### What happened?
   
   `.github/labeler.yml` has no glob that matches amber's binary-license
   manifests, so a PR that edits one gets **no stack label**, `precheck` selects
   no stacks, and the `build` job is skipped -- including the very check that
   validates the file that changed.
   
   The aggregate `Required Checks` gate treats `build: skipped` as passing, so such
   a PR goes **green without running anything**:
   
   ```
   edit amber/LICENSE-binary-python -> no stack label -> build: skipped -> Required Checks: success
   ```
   
   Every other module is covered because its label uses a directory-wide glob
   (`frontend/**`, `agent-service/**`, `access-control-service/**`, ...), so
   e.g. `frontend/LICENSE-binary` is picked up by `frontend`. `amber/` is the
   exception: it has no `amber/**`, and the `engine` / `pyamber` labels enumerate
   specific paths instead.
   
   Tracked files under `amber/` that currently match **no** labeler glob:
   
   | File | Validated by | Stack that should fire |
   | --- | --- | --- |
   | `amber/LICENSE-binary-python` | `check_binary_deps.py python` (pyamber 3.12) | `pyamber` |
   | `amber/LICENSE-binary-java` | `check_binary_deps.py jar` (amber) | `engine` |
   | `amber/NOTICE-binary` | `generate_notice_binary.py` regen+diff (amber) | `engine` |
   | `amber/NOTICE-binary-python` | same, via `--extras` (amber) | `engine` |
   | `amber/DESCRIPTION` | -- | (unclear -- separate question) |
   | `amber/src/bench/scala/**` | Benchmarks workflow | (unclear -- separate question) |
   
   This is the same hole the `pyamber` label's own comment already warns about one
   file over:
   
   > Without this a bumped requirements.txt would only get `dependencies` (no stack
   > mapping) and silently skip CI for the very deps it's changing.
   
   It bites in practice: #8293 fixes a repo-wide `pyamber` 3.12 license failure by
   adding one bullet to `amber/LICENSE-binary-python`, and its `build` job was
   skipped -- the `pyamber` label had to be applied by hand for the fix to be
   tested at all. The nightly exact-match refresh of those same pins would land the
   same way.
   
   ```
   Before:  edit amber/LICENSE-binary-python -> build skipped     -> green, untested
   After:   edit amber/LICENSE-binary-python -> pyamber stack runs -> license check actually gates it
   ```
   
   Suggested fix: add the four manifests to the globs of the label whose stack owns
   their check -- `amber/LICENSE-binary-python` under `pyamber`, and
   `amber/LICENSE-binary-java` / `amber/NOTICE-binary*` under `engine`. Whether
   `amber/DESCRIPTION` and `amber/src/bench/scala/**` want a mapping is a separate
   call.
   
   ### How to reproduce?
   
   1. Open a PR whose only change is a line in `amber/LICENSE-binary-python`
      (e.g. #8293 before the `pyamber` label was added by hand).
   2. `gh pr view <N> --repo apache/texera --json labels` -- no stack label, only
      the Conventional-Commit label from the title.
   3. `gh pr checks <N> --repo apache/texera` -- `build` reports `skipping`.
   4. The `Required Checks` gate still reports success, because its
      `results` loop accepts `skipped` alongside `success`.
   
   ### Version/Branch
   
   1.3.0-incubating-SNAPSHOT (main)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Edits to amber's LICENSE-binary and NOTICE-binary files skip the CI checks that validate them [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #8294:
URL: https://github.com/apache/texera/issues/8294#issuecomment-5480210266

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @aglinxinyuan!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Edits to amber's LICENSE-binary and NOTICE-binary files skip the CI checks that validate them [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on issue #8294:
URL: https://github.com/apache/texera/issues/8294#issuecomment-5481212944

   One correction that strengthens the case: the hand-applied label does **not** work around this. The issue reads "the `pyamber` label had to be applied by hand for the fix to be tested at all" — it was applied by hand, and #8293 still ran nothing.
   
   `.github/workflows/pr-labeler.yml:31` sets `sync-labels: true`, so the labeler removes labels whose globs no longer match — including ones a human added:
   
   ```
   2026-08-31T14:45:54Z  labeled    pyamber  by aglinxinyuan
   2026-08-31T16:12:10Z  unlabeled  pyamber  by github-actions[bot]
   ```
   
   And the sweep wins the race by design. `precheck` waits for the labeler to finish before reading labels — the comment at `precheck.yml:201` says *"Re-fetch labels: the labeler may have just added some"* — so it reads the set **after** the sweep:
   
   ```
   PR labels: fix, release/v1.2
   Stacks selected by label union: (none)
   ```
   
   So the sequence is:
   
   ```
   human adds pyamber -> next pull_request event -> labeler sweeps it (no matching glob)
                      -> precheck waits for labeler, re-fetches -> (none) -> every stack skipped
   ```
   
   Two consequences for the fix:
   
   1. There is no operator-side workaround today. Widening the globs isn't hygiene, it's the only route — a maintainer cannot force the stack on a LICENSE-binary-only PR, and re-labelling after the sweep only holds until the next event.
   2. `--label` on the PR at creation time fares no better, since the sweep happens on subsequent events.
   
   Meanwhile #8293's one-line change is verified out-of-band: `check_binary_deps.py` takes `--license-binary`, so pointing the real checker at each side of the diff with a `pip-licenses` CSV built from the manifest's own 109 packages plus `cloudpickle==3.1.2` gives `exit=1` with the exact CI line before and `OK: 110 Python packages match LICENSE-binary.` after. Details in https://github.com/apache/texera/pull/8293#issuecomment-5481207611. That is a workaround for one PR, not for the gap.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Edits to amber's LICENSE-binary and NOTICE-binary files skip the CI checks that validate them [texera]

Posted by "anthonychengit (via GitHub)" <gi...@apache.org>.
anthonychengit commented on issue #8294:
URL: https://github.com/apache/texera/issues/8294#issuecomment-5655211730

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org