You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "andreachild (via GitHub)" <gi...@apache.org> on 2025/07/18 17:45:40 UTC

[PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

andreachild opened a new pull request, #3161:
URL: https://github.com/apache/tinkerpop/pull/3161

   https://issues.apache.org/jira/browse/TINKERPOP-3141
   
   Account for the scenario of dropping and re-adding a vertex within the same transaction by adding a new `unmarkDeleted` method to the `TinkerElementContainer` and calling `unmarkDeleted` from `addVertex` if it is detected that the vertex had been previously deleted. Added logic to reference the previously deleted vertex version when adding the vertex back to avoid transaction conflict error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216808582


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {

Review Comment:
   I think this block should be a few lines higher, before throwing the error, something like
   ```
   if (container != null && container.isDeleted())
       container.unmarkDeleted((TinkerTransaction) tx());
   else if (container != null && container.get() != null)
       throw Exceptions.vertexWithIdAlreadyExists(idValue);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216994015


##########
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java:
##########
@@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() {
 
         assertFalse(vertex.inUse());
     }
+
+    @Test
+    public void shouldAllowDropThenInsertInSameTransaction() {

Review Comment:
   Will work on adding these new test cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216919114


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {
+            // vertex being added was previously deleted 
+            // we need to reference the version from the deleted state when adding the vertex back
+            version = container.getModified().version();
+            container.unmarkDeleted((TinkerTransaction) tx());
+        }
+        
         // no existing container, let's use new one
         if (container == null)
             container = newContainer;
 
-        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, txNumber);
+        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, version);

Review Comment:
   I think you're right, for scenario remove-add in same transaction better to preserve version, so `updatedOutsideTransaction()` will be correct. 
   and the test confirms it
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216833048


##########
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java:
##########
@@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() {
 
         assertFalse(vertex.inUse());
     }
+
+    @Test
+    public void shouldAllowDropThenInsertInSameTransaction() {

Review Comment:
   test scenarios that can be considered for reliability:
   - add and remove vertex with same ID in single transaction. It can be 4 tests, combinations like add-remove-add, add-remove-add-remove,  remove-add-remove-add, remove-add-remove. Existing tests covers only cases like add-remove, for example `shouldDeleteCreatedVertexOnCommit`
   - some multi-threaded test case, like remove-add in main thread (without commit) and remove-add-remove in another thread. Example of similar test is `shouldDeleteUnusedVertexContainerOnConcurrentVertexDelete`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216896726


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {
+            // vertex being added was previously deleted 
+            // we need to reference the version from the deleted state when adding the vertex back
+            version = container.getModified().version();
+            container.unmarkDeleted((TinkerTransaction) tx());
+        }
+        
         // no existing container, let's use new one
         if (container == null)
             container = newContainer;
 
-        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, txNumber);
+        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, version);

Review Comment:
   From my understanding the transaction number is specifically not set on the vertex until commit is called and until then, the vertex should retain the original version (except when adding a brand new vertex which will by default have a version set to the transaction number).
   
   ```
   public void commit(final long txVersion) {
       updateUsesCount();
       if (isDeletedInTx.get()) {
           // created and deleted in same tx
           if (null != element)
               element.removed = true;
           element = null;
           isDeleted = true;
       } else if (isModifiedInTx.get()){
           element = transactionUpdatedValue.get();
           element.currentVersion = txVersion;
       }
       reset();
   }
   ```
   
   Did I misunderstand?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216841401


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {
+            // vertex being added was previously deleted 
+            // we need to reference the version from the deleted state when adding the vertex back
+            version = container.getModified().version();
+            container.unmarkDeleted((TinkerTransaction) tx());
+        }
+        
         // no existing container, let's use new one
         if (container == null)
             container = newContainer;
 
-        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, txNumber);
+        final TinkerVertex vertex = new TinkerVertex(idValue, label, this, version);

Review Comment:
   If the element is changed in a transaction, the version must match the transaction number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2217157161


##########
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java:
##########
@@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() {
 
         assertFalse(vertex.inUse());
     }
+
+    @Test
+    public void shouldAllowDropThenInsertInSameTransaction() {

Review Comment:
   Added more comprehensive test cases including multi-threaded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216957307


##########
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java:
##########
@@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() {
 
         assertFalse(vertex.inUse());
     }
+
+    @Test
+    public void shouldAllowDropThenInsertInSameTransaction() {
+        final TinkerTransactionGraph g = TinkerTransactionGraph.open();
+        final TinkerTransaction tx = (TinkerTransaction) g.tx();
+        final int vertexId = 1;
+
+        // create initial vertex with a property
+        final GraphTraversalSource gtx = tx.begin();
+        gtx.addV().property(T.id, vertexId).property("name", "test").next();
+        gtx.tx().commit();
+
+        verifyCommittedSingleVertexWithId(g, vertexId);
+        final TinkerVertex originalVertex = g.getVertices().get(vertexId).getUnmodified();
+        assertEquals("test", originalVertex.properties.get("name").get(0).value());
+        final long originalVersion = originalVertex.version();
+
+        // drop the vertex and re-create it without any properties in the same transaction
+        final GraphTraversalSource gtx2 = tx.begin();
+        gtx2.V().drop().iterate();
+        gtx2.addV().property(T.id, vertexId).next();
+        gtx2.tx().commit();
+
+        verifyCommittedSingleVertexWithId(g, vertexId);
+        final TinkerElementContainer<TinkerVertex> container = g.getVertices().get(vertexId);
+        final TinkerVertex updatedVertex = container.getUnmodified();
+        assertNull(updatedVertex.properties);
+        // version should have been updated
+        assertNotEquals(originalVersion, updatedVertex.version());

Review Comment:
   Added check that original edge is dropped and remains dropped after adding the vertex back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090541509

   > @vkagamlyk would appreciate your feedback on this PR if you have the time 🙂
   
   Hi Andrea,
   thanks for trying to fix my bug :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216993882


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {

Review Comment:
   Ah yes I understand now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3091914875

   thank you!
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090486737

   @vkagamlyk would appreciate your feedback on this PR if you have the time 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216821853


##########
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java:
##########
@@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() {
 
         assertFalse(vertex.inUse());
     }
+
+    @Test
+    public void shouldAllowDropThenInsertInSameTransaction() {
+        final TinkerTransactionGraph g = TinkerTransactionGraph.open();
+        final TinkerTransaction tx = (TinkerTransaction) g.tx();
+        final int vertexId = 1;
+
+        // create initial vertex with a property
+        final GraphTraversalSource gtx = tx.begin();
+        gtx.addV().property(T.id, vertexId).property("name", "test").next();
+        gtx.tx().commit();
+
+        verifyCommittedSingleVertexWithId(g, vertexId);
+        final TinkerVertex originalVertex = g.getVertices().get(vertexId).getUnmodified();
+        assertEquals("test", originalVertex.properties.get("name").get(0).value());
+        final long originalVersion = originalVertex.version();
+
+        // drop the vertex and re-create it without any properties in the same transaction
+        final GraphTraversalSource gtx2 = tx.begin();
+        gtx2.V().drop().iterate();
+        gtx2.addV().property(T.id, vertexId).next();
+        gtx2.tx().commit();
+
+        verifyCommittedSingleVertexWithId(g, vertexId);
+        final TinkerElementContainer<TinkerVertex> container = g.getVertices().get(vertexId);
+        final TinkerVertex updatedVertex = container.getUnmodified();
+        assertNull(updatedVertex.properties);
+        // version should have been updated
+        assertNotEquals(originalVersion, updatedVertex.version());

Review Comment:
   Would be nice to throw in an edge on the vertex and ensure the edge remains dropped after gtx2 is committed
   ```suggestion
           gtx.addV().property(T.id, vertexId).property("name", "test").next();
           gtx.addE().from(V(vertexId)).to(V(vertexId))
           gtx.tx().commit();
   
           verifyCommittedSingleVertexWithId(g, vertexId);
           final TinkerVertex originalVertex = g.getVertices().get(vertexId).getUnmodified();
           assertEquals("test", originalVertex.properties.get("name").get(0).value());
           assertEquals(1, g.getEdgesCount());
           final long originalVersion = originalVertex.version();
   
           // drop the vertex and re-create it without any properties in the same transaction
           final GraphTraversalSource gtx2 = tx.begin();
           gtx2.V().drop().iterate();
           gtx2.addV().property(T.id, vertexId).next();
           gtx2.tx().commit();
   
           verifyCommittedSingleVertexWithId(g, vertexId);
           final TinkerElementContainer<TinkerVertex> container = g.getVertices().get(vertexId);
           final TinkerVertex updatedVertex = container.getUnmodified();
           assertNull(updatedVertex.properties);
           assertEquals(0, g.getEdgesCount());
           // version should have been updated
           assertNotEquals(originalVersion, updatedVertex.version());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216949693


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {

Review Comment:
   Moving the call to `unmarkDeleted` before the check for `vertexWithIdAlreadyExists` error would actually cause the error to be thrown because `unmarkDeleted` resets the `isDeletedInTx` value to `false` which causes `container.get()` to return non-null.
   
   ```
   /**
    * Get transaction specific value of stored element.
    */
   public T get() {
       if (isDeletedInTx.get()) return null;
       if (transactionUpdatedValue.get() != null) return transactionUpdatedValue.get();
       if (isDeleted) return null;
       return element;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216962810


##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
         if (container != null && container.get() != null)
             throw Exceptions.vertexWithIdAlreadyExists(idValue);
 
+        long version = txNumber;
+        if (container != null && container.isDeleted() && container.getModified() != null) {

Review Comment:
   `vertexWithIdAlreadyExists` is in `else if` block, so can't be thrown when `unmarkDeleted` called
   
   It's ok to leave it as you did if it works, it's too minor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090241171

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3161?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 74.22%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`83537b7`)](https://app.codecov.io/gh/apache/tinkerpop/commit/83537b78fbb213172c08a34f3ca4f84fd4dffa57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 349 commits behind head on 3.7-dev.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.7-dev    #3161      +/-   ##
   =============================================
   - Coverage      76.14%   74.22%   -1.92%     
   =============================================
     Files           1084       28    -1056     
     Lines          65160     5913   -59247     
     Branches        7285        0    -7285     
   =============================================
   - Hits           49616     4389   -45227     
   + Misses         12839     1322   -11517     
   + Partials        2705      202    -2503     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3161?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090560587

   LGTM VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3141 Allow drop add vertex in same transaction [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090903404

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org