You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/06 02:36:08 UTC

[GitHub] [orc] coderex2522 commented on a diff in pull request #1073: ORC-969: [C++] Evaluate SearchArguments using file and stripe level stats

coderex2522 commented on code in PR #1073:
URL: https://github.com/apache/orc/pull/1073#discussion_r843408965


##########
c++/src/Reader.hh:
##########
@@ -254,7 +255,6 @@ namespace orc {
                                std::vector<std::vector<proto::ColumnStatistics> >* indexStats) const;
 
     // metadata
-    mutable std::unique_ptr<proto::Metadata> metadata;
     mutable bool isMetadataLoaded;

Review Comment:
   Because the Metadata variable need to be consumed in RowReaderImpl class and the isMetadataLoaded flag don't be consumed in RowReaderImpl.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org