You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/20 03:20:03 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3035: Move o.a.a.fate to o.a.a.core.fate
ctubbsii opened a new pull request, #3035:
URL: https://github.com/apache/accumulo/pull/3035
Relocate classes from org.apache.accumulo.fate into an appropriate org.apache.accumulo.core subpackage, in order to ensure a consistent naming scheme and to ensure all packages in the accumulo-core.jar fall under a common package that is unique to the jar. This ensures that we are prepared for any future exports for the JPMS system, and helps us locate the correct jar given a class name in a stack trace.
This is being done for 2.1, because fate already has breaking changes from earlier versions, and upgrading to 2.1 already requires no outstanding fate operations.
* Relocate UtilWaitThread and Retry classes from org.apache.accumulo.fate.util to org.apache.accumulo.core.util
* Relocate org.apache.accumulo.fate and its remaining subpackages into org.apache.accumulo.core.fate and subpackages under that
* Move unit tests also
* Also remove mentions of accumulo-fate jar and the fate module from the test resource's accumulo-site.xml for the manager's upgrade tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3035: Move o.a.a.fate to o.a.a.core.fate
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3035:
URL: https://github.com/apache/accumulo/pull/3035#issuecomment-1284899997
Since this is a trivial package rename change that brings things into alignment with existing naming conventions for the project, there's not really anything to review here, and all the ITs passed, so I'm going to go ahead and merge this. If there's an issue with this, it will be trivial to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3035: Move o.a.a.fate to o.a.a.core.fate
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #3035:
URL: https://github.com/apache/accumulo/pull/3035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3035: Move o.a.a.fate to o.a.a.core.fate
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3035:
URL: https://github.com/apache/accumulo/pull/3035#issuecomment-1284897581
All ITs pass, but saw FateStarvationIT flake out once, before passing on subsequent runs. This is a known flaky test (See #1790), and it passed on subsequent runs, so it's not related to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org