You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Mathieu Lirzin (JIRA)" <ji...@apache.org> on 2019/02/04 22:39:00 UTC
[jira] [Comment Edited] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760273#comment-16760273 ]
Mathieu Lirzin edited comment on OFBIZ-10606 at 2/4/19 10:38 PM:
-----------------------------------------------------------------
I have kept the {{git format-patch}} metadata on the diff since they provide an overview/context/rationale of the changes made on each patch which can be helpful when reviewing and for the commits message. Please let me know if I need to clean things up, since it appears to confuse reviewer sometimes.
was (Author: mthl):
I have kept the {{git format-patch}} metadata on the diff since they provide an overview/context/rationale of the changes made on each patch which can be helpful to review and for the commits message. Please let me know if I need to clean things up, since it appears to confuse reviewer sometimes.
> Webapp related code should be extracted from ‘ComponentConfig’
> ---------------------------------------------------------------
>
> Key: OFBIZ-10606
> URL: https://issues.apache.org/jira/browse/OFBIZ-10606
> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch, OFBIZ-10606_0001-Add-WebAppCache.patch, OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch, OFBIZ-10606_0003-Refactor-WebAppCache.patch, OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch, OFBIZ-10606_0005-Use-Optional-for-getWebappInfo.patch
>
>
> The {{ComponentConfig}} mixes various concerns which should be separated to make the code more understandable. The method touching the {{serverWebApps}} static member could be put in a separated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)