You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Daniel Kulp <dk...@apache.org> on 2009/10/08 22:22:47 UTC
Re: svn commit: r823260 - /cxf/trunk/systests/pom.xml
Chris,
I think this is going to break deploys pretty bad. The two submodules
(codegen/ java2ws) currently don't have the main cxf pom in the parent
heiarchy at all. Thus, things like the distribution mgmt section and stuff
are not inherited. Could these be updated to use the correct parents without
causing issues?
Dan
On Thu October 8 2009 2:34:35 pm cschneider@apache.org wrote:
> Author: cschneider
> Date: Thu Oct 8 18:34:35 2009
> New Revision: 823260
>
> URL: http://svn.apache.org/viewvc?rev=823260&view=rev
> Log:
> Activate wsdl_maven systest
>
> Modified:
> cxf/trunk/systests/pom.xml
>
> Modified: cxf/trunk/systests/pom.xml
> URL:
> http://svn.apache.org/viewvc/cxf/trunk/systests/pom.xml?rev=823260&r1=8232
> 59&r2=823260&view=diff
> ==========================================================================
> ==== --- cxf/trunk/systests/pom.xml (original)
> +++ cxf/trunk/systests/pom.xml Thu Oct 8 18:34:35 2009
> @@ -38,6 +38,7 @@
> <module>databinding</module>
> <module>jaxrs</module>
> <module>ws-specs</module>
> + <module>wsdl_maven</module>
> </modules>
>
> </project>
>
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: svn commit: r823260 - /cxf/trunk/systests/pom.xml
Posted by Daniel Kulp <dk...@apache.org>.
On Thu October 8 2009 4:43:56 pm Christian Schneider wrote:
> the parent should do no harm. I have added parent elements to both poms.
> After checkstyle kicked in I also had to the license header. Just
> committed the three changes.
>
Ah. Finding license issues is a good thing!
> Btw. I had taken the parent from the jms project. This had a relative
> path while the pom for systests does not have this element. Can you tell
> me when relativePath should be used?
Well, if the parent isn't in "..", then a relative path should be used. For
the most part, that means any "jar" packaging things should have a relative
path to cxf-parent so they pick up the java compiler settings (java 1.5,
checkstyle/pmd rules, eclipse setup things, etc..).
For the most part, it's not a big deal if they are left out. It's only
really needed if you do a "mvn install" or something in a subdirectory if you
HAVEN'T already done a mvn install top level. Pretty rare in our case and
I'm not sure that would work anyway.
Dan
> Greetings
>
> Christian
>
> Daniel Kulp schrieb:
> > Chris,
> >
> > I think this is going to break deploys pretty bad. The two submodules
> > (codegen/ java2ws) currently don't have the main cxf pom in the parent
> > heiarchy at all. Thus, things like the distribution mgmt section and
> > stuff are not inherited. Could these be updated to use the correct
> > parents without causing issues?
> >
> > Dan
> >
> > On Thu October 8 2009 2:34:35 pm cschneider@apache.org wrote:
> >> Author: cschneider
> >> Date: Thu Oct 8 18:34:35 2009
> >> New Revision: 823260
> >>
> >> URL: http://svn.apache.org/viewvc?rev=823260&view=rev
> >> Log:
> >> Activate wsdl_maven systest
> >>
> >> Modified:
> >> cxf/trunk/systests/pom.xml
> >>
> >> Modified: cxf/trunk/systests/pom.xml
> >> URL:
> >>
> >> http://svn.apache.org/viewvc/cxf/trunk/systests/pom.xml?rev=823260&r1=82
> >>32 59&r2=823260&view=diff
> >>
> >> ========================================================================
> >>== ==== --- cxf/trunk/systests/pom.xml (original)
> >> +++ cxf/trunk/systests/pom.xml Thu Oct 8 18:34:35 2009
> >> @@ -38,6 +38,7 @@
> >> <module>databinding</module>
> >> <module>jaxrs</module>
> >> <module>ws-specs</module>
> >> + <module>wsdl_maven</module>
> >> </modules>
> >>
> >> </project>
>
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: svn commit: r823260 - /cxf/trunk/systests/pom.xml
Posted by Christian Schneider <ch...@die-schneider.net>.
Hi Dan,
the parent should do no harm. I have added parent elements to both poms.
After checkstyle kicked in I also had to the license header. Just
committed the three changes.
Btw. I had taken the parent from the jms project. This had a relative
path while the pom for systests does not have this element. Can you tell
me when relativePath should be used?
Greetings
Christian
Daniel Kulp schrieb:
> Chris,
>
> I think this is going to break deploys pretty bad. The two submodules
> (codegen/ java2ws) currently don't have the main cxf pom in the parent
> heiarchy at all. Thus, things like the distribution mgmt section and stuff
> are not inherited. Could these be updated to use the correct parents without
> causing issues?
>
> Dan
>
>
> On Thu October 8 2009 2:34:35 pm cschneider@apache.org wrote:
>
>> Author: cschneider
>> Date: Thu Oct 8 18:34:35 2009
>> New Revision: 823260
>>
>> URL: http://svn.apache.org/viewvc?rev=823260&view=rev
>> Log:
>> Activate wsdl_maven systest
>>
>> Modified:
>> cxf/trunk/systests/pom.xml
>>
>> Modified: cxf/trunk/systests/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/cxf/trunk/systests/pom.xml?rev=823260&r1=8232
>> 59&r2=823260&view=diff
>> ==========================================================================
>> ==== --- cxf/trunk/systests/pom.xml (original)
>> +++ cxf/trunk/systests/pom.xml Thu Oct 8 18:34:35 2009
>> @@ -38,6 +38,7 @@
>> <module>databinding</module>
>> <module>jaxrs</module>
>> <module>ws-specs</module>
>> + <module>wsdl_maven</module>
>> </modules>
>>
>> </project>
>>
>>
>
>
--
Christian Schneider
---
http://www.liquid-reality.de