You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org> on 2010/03/17 08:42:27 UTC
[jira] Commented: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846328#action_12846328 ]
Reto Bachmann-Gmür commented on CLEREZZA-163:
---------------------------------------------
both in test and actual code it's convention to start method names with lower case characters (just what occurs to me having a hard time understand the overall code)
NEXTLINE = "\n".getBytes()[0]; is a bit awkward for NEXTLINE = '\n';
RemoveXmlDeclarationAndDotnotAddDoctypeIfHtmlNotComplete, apart from the casing there's a typo
I think the code could be more readable but given that the tests seem rather complete, I'd say its acceptable now.
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.