You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/26 02:57:04 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #299: Support producer name for Message
wolfstudy opened a new pull request #299:
URL: https://github.com/apache/pulsar-client-go/pull/299
Signed-off-by: xiaolong.ran <rx...@apache.org>
Fixes #295
### Motivation
Support producer name for Message interface, allows the user to get the `producerName` of the message in the received message.
```
msg, err := consumer.Receive(context.Background())
if err != nil {
log.Fatal(err)
}
log.Println(msg.ProducerName())
```
### Modifications
- add `producerName` filed to `message` struct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #299: Support producer name for Message
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #299:
URL: https://github.com/apache/pulsar-client-go/pull/299#issuecomment-649926347
@merlimat Hello, currently, the Jenkinns CI still running, Do we need to do anything else for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #299: Support producer name for Message
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #299:
URL: https://github.com/apache/pulsar-client-go/pull/299#issuecomment-649926839
@JoseFMP PTAL thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #299: Support producer name for Message
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #299:
URL: https://github.com/apache/pulsar-client-go/pull/299#discussion_r445954733
##########
File path: pulsar/message.go
##########
@@ -64,6 +64,9 @@ type Message interface {
// Topic get the topic from which this message originated from
Topic() string
+ // ProducerName will get producer name from broker
Review comment:
Saying "from broker" can be misleading since we're not fetching it from the broker, rather the name comes attached to the message metadata.
In Java client doc we have:
```
Get the producer name who produced this message.
```
```suggestion
// ProducerName returns the name of the producer that has published the message
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #299: Support producer name for Message
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #299:
URL: https://github.com/apache/pulsar-client-go/pull/299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org