[GitHub] [zookeeper] eolivelli commented on a change in pull request #1220: ZOOKEEPER-2293 Log warning msg once by adding flag

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1220: ZOOKEEPER-2293 Log warning msg once by adding flag
URL: https://github.com/apache/zookeeper/pull/1220#discussion_r366523635
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -1348,15 +1348,19 @@ public void processConnectRequest(ServerCnxn cnxn, ByteBuffer incomingBuffer)
         ServerMetrics.getMetrics().CONNECTION_REQUEST_COUNT.add(1);
 
         boolean readOnly = false;
+        boolean logWarning = false;
 
 Review comment:
   With **lpgWarning** I would expect a **true** value as initial value.
   With current approach I would name the variable as **warningLogged**
   
   Btw did you mean to declare the variable as a instance field?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services