[GitHub] [geode] balesh2 opened pull request #2455: GEODE-5712: move awaitility into invoked runnable

["balesh2 (GitHub)" <gi...@apache.org>]

Assertion errors within invoked runnables get wrapped in an
RMIException, so untilAsserted does not recognize them as failed
assertions. Since they are treated as unexpected errors, awaitility
does not loop.  Moving the awaitility inside the invocation gives us the
expected behavior.

Signed-off-by: Dale Emery<de...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2455 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 closed pull request #2455: GEODE-5499: move awaitility into invoked runnable

["balesh2 (GitHub)" <gi...@apache.org>]

[ pull request closed by balesh2 ]

[ Full content available at: https://github.com/apache/geode/pull/2455 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org