[jira] [Commented] (CALCITE-3934) Supports implicit type coercion for operators with repeated type families

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086041#comment-17086041 ] 

Julian Hyde commented on CALCITE-3934:
--------------------------------------

Thanks for capitalizing {{@param}} descriptions. But don't capitalize {{@return}}, e.g. leave {{@return Tightest common type}} as {{@return tightest common type}}; it is not a sentence.

(My personal preference is to omit {{@return}} if the return is clear from the method description, especially if deriving that return code is the main purpose of the method.)

Subject of this case and commit should be "Allow type-coercion in CONCAT operator". The infrastructure work you did for other operators is secondary - and more abstract - and can be mentioned in the description.

Is the '||' operator also affected? Hope so. (I think there is a Jira case logged for that already. Can you link it to this?)

Any doc changes needed? Probably not.

Javadoc: "Try to coerce" should be "Tries to coerce".

> Supports implicit type coercion for operators with repeated type families
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-3934
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3934
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Supports implicit type coercion for operators with repeated type families, such as:
> {code:sql}
> CONCAT(123, 'abc', DATE '2020-04-17')
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)