You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 19:48:06 UTC
[GitHub] [airflow] lsowen opened a new issue #13070: KubernetesPodOperator duplicate code
lsowen opened a new issue #13070:
URL: https://github.com/apache/airflow/issues/13070
Does anyone know why there are two calls to `create_pod_request_obj()` and `create_labels_for_pod()` in https://github.com/apache/airflow/blob/c743b95a02ba1ec04013635a56ad042ce98823d2/airflow/contrib/operators/kubernetes_pod_operator.py#L278-L287
It looks like maybe a merge issue between two different PRs that got merged at approximately the same time? (#11162 and #10963)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #13070: KubernetesPodOperator duplicate call to create_pod_request_obj()
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13070:
URL: https://github.com/apache/airflow/issues/13070#issuecomment-746557199
You are viewing old version.
You should import the operator from providers:
https://github.com/apache/airflow/blob/bd90136aaf5035e3234fe545b79a3e4aad21efe2/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #13070: KubernetesPodOperator duplicate call to create_pod_request_obj()
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13070:
URL: https://github.com/apache/airflow/issues/13070#issuecomment-747508534
You can install [backport provider package](https://pypi.org/project/apache-airflow-backport-providers-cncf-kubernetes/) which is compatible with 1.10.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #13070: KubernetesPodOperator duplicate code
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13070:
URL: https://github.com/apache/airflow/issues/13070#issuecomment-744669631
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #13070: KubernetesPodOperator duplicate call to create_pod_request_obj()
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #13070:
URL: https://github.com/apache/airflow/issues/13070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lsowen commented on issue #13070: KubernetesPodOperator duplicate call to create_pod_request_obj()
Posted by GitBox <gi...@apache.org>.
lsowen commented on issue #13070:
URL: https://github.com/apache/airflow/issues/13070#issuecomment-747507273
It looks like it has been fixed in `master`, but is still an issue in the `v1-10-stable` (https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/operators/kubernetes_pod_operator.py#L278-L286)
Will there be any further 1.10.x releases? Or is v2.0.0 the next release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org