You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4net-dev@logging.apache.org by bodewig <gi...@git.apache.org> on 2015/04/05 15:52:17 UTC

[GitHub] log4net pull request: Support for types with non-parameter less co...

Github user bodewig commented on the pull request:

    https://github.com/apache/log4net/pull/10#issuecomment-89774707
  
    Almost a year, wow.  Sorry about that.
    
    https://github.com/apache/log4net/compare/trunk...bodewig:github-pr10?expand=1 contains a rebased version of your PR - I've made the original and your change's indentations match so it is easier to see what has been changed.
    
    We should probably try to make this work for .NET 2.0 as well, so the LINQ stuff needs to be replaced, which will certainly make the change look bigger.
    
    Also, it would be good to have unit tests for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---