[GitHub] mistercrunch closed pull request #6292: [bugfix] handle Loading spinner properly

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #6292: [bugfix] handle Loading spinner properly
URL: https://github.com/apache/incubator-superset/pull/6292
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index b6bc8d7d9c..a4be8dcc86 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
       >
         {this.renderTooltip()}
 
-        {chartStatus !== 'rendered' && <Loading size={50} />}
+        {['loading', 'success'].indexOf(chartStatus) >= 0 && <Loading size={50} />}
 
         {chartAlert && (
           <StackTraceMessage


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org