You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/03/10 08:56:37 UTC

Re: [PR] [SPARK-55918][SQL][CONNECT] Rewrite spark.catalog getDatabase / databaseExists in SQL DDL [spark]

zhengruifeng commented on code in PR #54718:
URL: https://github.com/apache/spark/pull/54718#discussion_r2910279092


##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/Catalog.scala:
##########
@@ -23,11 +23,73 @@ import org.apache.spark.sql.catalog.{CatalogMetadata, Column, Database, Function
 import org.apache.spark.sql.catalyst.ScalaReflection
 import org.apache.spark.sql.catalyst.encoders.AgnosticEncoder
 import org.apache.spark.sql.catalyst.encoders.AgnosticEncoders.{PrimitiveBooleanEncoder, StringEncoder}
+import org.apache.spark.sql.catalyst.util.QuotingUtils
 import org.apache.spark.sql.connect.common.{DataTypeProtoConverter, StorageLevelProtoConverter}
+import org.apache.spark.sql.internal.{DDLBasedCatalog, SqlApiConf}
 import org.apache.spark.sql.types.StructType
 import org.apache.spark.storage.StorageLevel
 
-class Catalog(sparkSession: SparkSession) extends catalog.Catalog {
+class Catalog(sparkSession: SparkSession) extends catalog.Catalog with DDLBasedCatalog {

Review Comment:
   do you plan to make similar changes in python client in followup PRs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org