You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/07/13 09:45:23 UTC

[GitHub] [lucene-solr] mocobeta opened a new pull request #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x

mocobeta opened a new pull request #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
URL: https://github.com/apache/lucene-solr/pull/782
 
 
   # Description
   
   Backport LUCENE-8778 to 8.x and also keep legacy look-up algorithm for backwards compatibility.
   See also: https://issues.apache.org/jira/browse/LUCENE-8911
   
   # Solution
   
   Make it possible to load analysis factories by both of new/legacy SPI names.
   
   # Tests
   
   I added tests for the following cases:
   - A factory lacks the NAME field: register the legacy name only.
   - A factory has the NAME field but it does not match to the legacy name, which is derived from the class name.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - ~~[] I have developed this patch against the `master` branch.~~
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - ~~[] I have added documentation for the Ref Guide (for Solr changes only).~~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org