You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/23 17:42:15 UTC

[GitHub] KellenSunderland commented on a change in pull request #12804: CudnnFind() usage improvements

KellenSunderland commented on a change in pull request #12804: CudnnFind() usage improvements
URL: https://github.com/apache/incubator-mxnet/pull/12804#discussion_r227495493
 
 

 ##########
 File path: perl-package/AI-MXNetCAPI/mxnet.i
 ##########
 @@ -349,7 +349,7 @@ int MXGetGPUCount(int* out);
  * \param total_mem pointer to the integer holding total GPU memory
  * \return 0 when success, -1 when failure happens
  */
-int MXGetGPUMemoryInformation(int dev, int *out, int *out);
+int MXGetGPUMemoryInformation(int dev, uint64_t *out, uint64_t *out);
 
 Review comment:
   @szha Given the usage I'd consider this a non-breaking change, but it is technically changing types to an argument.  From a SemVer perspective are you ok with changing this in a minor update?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services