You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/01/20 15:31:45 UTC

[GitHub] jmeter pull request: Bug 58897 : DO NOT MERGE AS THIS !!!

GitHub user benbenw opened a pull request:

    https://github.com/apache/jmeter/pull/84

    Bug 58897 : DO NOT MERGE AS THIS !!!

    Some code added a few years ago silently disabled a *lot* of tests : 
    when run in headless mode (apache build bot ?) a HeadlessException is
    thrown but wrapped in an ExceptionInInitializerError
    this error stop the JmeterTest suite and the following tests are
    disabled
    - suiteSerializableElements
    - suiteTestElements
    - suiteBeanComponents
    - new JMeterTest("createFunctionSet"));
    - suiteFunctions
    - new JMeterTest("checkGuiSet"));
    - new JMeterTest("checkFunctionSet"));        
    - new JMeterTest("resetLocale")
    
    this patch will re-enable those tests but some of them fail
    Those tests need to be reviewed by a jmeter ninja or an archaeologist

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benbenw/jmeter enabletests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit db59c23c593f3a75350f98fb4f0224774fe17ebf
Author: benoit <b....@ubik-ingenierie.com>
Date:   2016-01-20T14:28:30Z

    DO NOT MERGE AS THIS !!!
    
    Some code added a few years ago silently disabled a *lot* of tests : 
    when run in headless mode (apache build bot ?) a HeadlessException is
    thrown but wrapped in an ExceptionInInitializerError
    this error stop the JmeterTest suite and the following tests are
    disabled
    - suiteSerializableElements
    - suiteTestElements
    - suiteBeanComponents
    - new JMeterTest("createFunctionSet"));
    - suiteFunctions
    - new JMeterTest("checkGuiSet"));
    - new JMeterTest("checkFunctionSet"));        
    - new JMeterTest("resetLocale")
    
    this patch will re-enable those tests but some of them fail

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug 58897 : DO NOT MERGE AS THIS !!!

Posted by benbenw <gi...@git.apache.org>.
Github user benbenw closed the pull request at:

    https://github.com/apache/jmeter/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---