You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/04 20:00:00 UTC
[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency
on DistributionMessage
[ https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988166#comment-16988166 ]
ASF subversion and git services commented on GEODE-7507:
--------------------------------------------------------
Commit 0c1b33f586fff12ae8c3c9fef1635cac792eee09 in geode's branch refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0c1b33f ]
GEODE-7507 remove GMSMembership's dependency on DistributionMessage (#4384)
* GEODE-7507 remove GMSMembership's dependency on DistributionMessage
Prior to this change-set the membership module wrapped all messages in a
GMSMessageAdapter. This is no longer necessary and I've deleted that
class. Instead, our messages now implement GMSMessage (now renamed
DistributionMessage) and the geode-core abstract DistributionMessage
class (now renamed ClusterMessage) implements the membership module's
API.
Most of the files in the diff are only affected by the renaming of
GMSMessage and DistributionMessage. The primary changes are in GMSManager
and DistributionMessage (now named ClusterMessage).
* rebase on develop, rename DistributionMessageObserver
* making pmdMain happy
* revert renaming message class/interface
* fix serialization test
* rename GMSMessage to Message
* fixes for Dan's comments
* addressing pmdMain issue
* removing DistributionMessage from another arch unit test
> remove GMSMembership's dependency on DistributionMessage
> --------------------------------------------------------
>
> Key: GEODE-7507
> URL: https://issues.apache.org/jira/browse/GEODE-7507
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> GMSMembership should not refer to DistributionMessage, a geode-core class. This is preventing membership from being moved to a separate sub-project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)