[jira] [Updated] (SENTRY-513) Sentry web service may not be stoped completely

["Dapeng Sun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SENTRY-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dapeng Sun updated SENTRY-513:
------------------------------
    Attachment: SENTRY-513.002.patch

> Sentry web service may not be stoped completely
> -----------------------------------------------
>
>                 Key: SENTRY-513
>                 URL: https://issues.apache.org/jira/browse/SENTRY-513
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-513.002.patch, SENTRY-513.patch
>
>
> {code}
>  public synchronized void stop() throws Exception{
>     if (status == Status.NOT_STARTED) {
>       return;
>     }
>     LOGGER.info("Attempting to stop...");
>     if (thriftServer.isServing()) {
>       thriftServer.stop(); // XXX If got exception here, the code after it will never be executed. 
>     }
>     thriftServer = null;
>     stopSentryWebServer();
>     status = Status.NOT_STARTED;
>     LOGGER.info("Stopped...");
>   }
> {code} 
> if {{thriftServer}} got an exception when do stop, the method {{stopSentryWebServer()}} will be passed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)