You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/21 20:46:00 UTC

[jira] [Commented] (MNG-7020) Remove Maven 2 WagonExcluder backward compat code

    [ https://issues.apache.org/jira/browse/MNG-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569683#comment-17569683 ] 

ASF GitHub Bot commented on MNG-7020:
-------------------------------------

michael-o opened a new pull request, #775:
URL: https://github.com/apache/maven/pull/775

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue. Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
          title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Remove Maven 2 WagonExcluder backward compat code
> -------------------------------------------------
>
>                 Key: MNG-7020
>                 URL: https://issues.apache.org/jira/browse/MNG-7020
>             Project: Maven
>          Issue Type: Task
>          Components: Class Loading, Dependencies
>    Affects Versions: 3.6.3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>              Labels: must-be-in-4.0.0-alpha-2
>             Fix For: 4.0.x-candidate
>
>         Attachments: mng5669-log_post-mng7020.txt, mng5669-log_pre-mng7020.txt
>
>
> Maven includes a Wagon Excluder when Maven 2 artifacts are used with Wagon 1.0.x: https://maven.apache.org/ref/3.8.4/maven-core/xref/org/apache/maven/plugin/internal/WagonExcluder.html
> This is ancient Maven 2 backward compat.
> Let's remove it and hope everyone has moved on to Maven 3.x artifacts and Wagon 3.x.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)