[GitHub] [spark] srielau commented on a diff in pull request #38937: [SPARK-41406][SQL] Refactor error message for `NUM_COLUMNS_MISMATCH` to make it more generic

[GitBox <gi...@apache.org>]

srielau commented on code in PR #38937:
URL: https://github.com/apache/spark/pull/38937#discussion_r1042786058


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -932,7 +932,7 @@
   },
   "NUM_COLUMNS_MISMATCH" : {
     "message" : [
-      "<operator> can only be performed on tables with the same number of columns, but the first table has <refNumColumns> columns and the <invalidOrdinalNum> table has <invalidNumColumns> columns."
+      "<operator> expects matching number of columns. But the left side (target) has <leftNumCols> while the right side (source) has <rightNumCols>."

Review Comment:
   I'm thinking of the operator being UNION (hence left and right).
   So:
   SET
   INSERT
   UNION
   INTERSECT
   EXCEPT 
   IN (?) -- this may go through struct logic not sure)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org