You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gitccl (via GitHub)" <gi...@apache.org> on 2023/04/16 06:48:54 UTC
[GitHub] [doris] gitccl opened a new pull request, #18702: [Enhancement](compaction) stop tablet compaction when table dropped
gitccl opened a new pull request, #18702:
URL: https://github.com/apache/doris/pull/18702
# Proposed changes
Issue Number: close #18446
## Problem summary
When table was dropped without FORCE, tablet in be will still do compaction as current tablet in be has no information about table status in fe.
To solve this problem, we add a field `is_dropped` to both fe and be 's TabletMeta to indicate whether the tablet is dropped, and tablet with `is_dropped=true` will not be compacted.
When a table was dropped, the `is_dropped` in fe's TabletMeta will be set to true. When be reports tablet to fe, fe will compare be's `is_dropped` with its own. If it is different, fe will send an UPDATE_TABLET_META_INFO AgentTask to be to change be's `is_dropped`.
The recover process is similar to the above.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510615899
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1511060551
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "yixiutt (via GitHub)" <gi...@apache.org>.
yixiutt commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510967987
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510970204
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "gitccl (via GitHub)" <gi...@apache.org>.
gitccl commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1519017189
@zhannngchen Hi, can this pr be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "gitccl (via GitHub)" <gi...@apache.org>.
gitccl commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510121122
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18702:
URL: https://github.com/apache/doris/pull/18702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "gitccl (via GitHub)" <gi...@apache.org>.
gitccl commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510615730
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18702:
URL: https://github.com/apache/doris/pull/18702#issuecomment-1510123889
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org