You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/23 15:51:12 UTC

Review Request 27079: Ambari Kafka charts on service page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27079/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-7922
    https://issues.apache.org/jira/browse/AMBARI-7922


Repository: ambari


Description
-------

kafka stack definition exposes ganglia published metrics. We want to display some of those metrics on service page.
metrics/kafka/server/BrokerTopicMetrics/AllTopicsMessagesInPerSec/1MinuteRate
metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesInPerSec/1MinuteRate
metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesOutPerSec/1MinuteRate
metrics/kafka/controller/KafkaController/ActiveControllerCount
metrics/kafka/log/LogFlushStats/LogFlushRateAndTimeMs/1MinuteRate
metrics/kafka/controller/ControllerStats/LeaderElectionRateAndTimeMs/1MinuteRate
metrics/kafka/controller/ControllerStats/OfflinePartitionsCount
metrics/kafka/server/ReplicaManager/PartitionCount
metrics/kafka/server/ReplicaManager/UnderReplicatedPartitions
metrics/kafka/server/ReplicaManager/LeaderCount
metrics/kafka/server/ReplicaFetcherManager/Replica-MaxLag


Diffs
-----

  ambari-web/app/data/service_graph_config.js 51a9f9e 
  ambari-web/app/messages.js 2ef3ffa 
  ambari-web/app/utils/ajax/ajax.js 4d2cd2c 
  ambari-web/app/views.js 12b2683 
  ambari-web/app/views/main/service/info/metrics/kafka/broker_topic.js PRE-CREATION 
  ambari-web/app/views/main/service/info/metrics/kafka/controller_status.js PRE-CREATION 
  ambari-web/app/views/main/service/info/metrics/kafka/kafka_controller.js PRE-CREATION 
  ambari-web/app/views/main/service/info/metrics/kafka/kafka_log_flush.js PRE-CREATION 
  ambari-web/app/views/main/service/info/metrics/kafka/replica_fetcher.js PRE-CREATION 
  ambari-web/app/views/main/service/info/metrics/kafka/replica_manager.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27079/diff/


Testing
-------

tested manually


Thanks,

Andriy Babiichuk

Re: Review Request 27079: Ambari Kafka charts on service page

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27079/#review57987
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Oct. 23, 2014, 1:51 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27079/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 1:51 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7922
>     https://issues.apache.org/jira/browse/AMBARI-7922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> kafka stack definition exposes ganglia published metrics. We want to display some of those metrics on service page.
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsMessagesInPerSec/1MinuteRate
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesInPerSec/1MinuteRate
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesOutPerSec/1MinuteRate
> metrics/kafka/controller/KafkaController/ActiveControllerCount
> metrics/kafka/log/LogFlushStats/LogFlushRateAndTimeMs/1MinuteRate
> metrics/kafka/controller/ControllerStats/LeaderElectionRateAndTimeMs/1MinuteRate
> metrics/kafka/controller/ControllerStats/OfflinePartitionsCount
> metrics/kafka/server/ReplicaManager/PartitionCount
> metrics/kafka/server/ReplicaManager/UnderReplicatedPartitions
> metrics/kafka/server/ReplicaManager/LeaderCount
> metrics/kafka/server/ReplicaFetcherManager/Replica-MaxLag
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/service_graph_config.js 51a9f9e 
>   ambari-web/app/messages.js 2ef3ffa 
>   ambari-web/app/utils/ajax/ajax.js 4d2cd2c 
>   ambari-web/app/views.js 12b2683 
>   ambari-web/app/views/main/service/info/metrics/kafka/broker_topic.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/controller_status.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/kafka_controller.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/kafka_log_flush.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/replica_fetcher.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/replica_manager.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27079/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 27079: Ambari Kafka charts on service page

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27079/#review57986
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 23, 2014, 1:51 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27079/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 1:51 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7922
>     https://issues.apache.org/jira/browse/AMBARI-7922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> kafka stack definition exposes ganglia published metrics. We want to display some of those metrics on service page.
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsMessagesInPerSec/1MinuteRate
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesInPerSec/1MinuteRate
> metrics/kafka/server/BrokerTopicMetrics/AllTopicsBytesOutPerSec/1MinuteRate
> metrics/kafka/controller/KafkaController/ActiveControllerCount
> metrics/kafka/log/LogFlushStats/LogFlushRateAndTimeMs/1MinuteRate
> metrics/kafka/controller/ControllerStats/LeaderElectionRateAndTimeMs/1MinuteRate
> metrics/kafka/controller/ControllerStats/OfflinePartitionsCount
> metrics/kafka/server/ReplicaManager/PartitionCount
> metrics/kafka/server/ReplicaManager/UnderReplicatedPartitions
> metrics/kafka/server/ReplicaManager/LeaderCount
> metrics/kafka/server/ReplicaFetcherManager/Replica-MaxLag
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/service_graph_config.js 51a9f9e 
>   ambari-web/app/messages.js 2ef3ffa 
>   ambari-web/app/utils/ajax/ajax.js 4d2cd2c 
>   ambari-web/app/views.js 12b2683 
>   ambari-web/app/views/main/service/info/metrics/kafka/broker_topic.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/controller_status.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/kafka_controller.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/kafka_log_flush.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/replica_fetcher.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/metrics/kafka/replica_manager.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27079/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>