You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/04/03 21:43:03 UTC
Review Request 58162: GEM-1351: Move a test to the open side and fix
the other tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/
-----------------------------------------------------------
Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
* move ImportClusterConfigDistributedTest to open side
* remove @Ignore from other two tests.
* force the isGfshVM flag to be false before exeuting the command since class loading issue still contaminate the close
side test environment.
Diffs
-----
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 2d648bd599c57b91252aaf37bce4bf0635c4eda6
Diff: https://reviews.apache.org/r/58162/diff/1/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 58162: GEM-1351: Move a test to the open side and
fix the other tests
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/#review171018
-----------------------------------------------------------
Fix it, then Ship it!
Please consider making vars and method private and then ShipIt!
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
Lines 43 (patched)
<https://reviews.apache.org/r/58162/#comment243848>
Can we make these vars private? I've seen previous dunit tests become entwined by accessing each others variables and other craziness.
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
Lines 80 (patched)
<https://reviews.apache.org/r/58162/#comment243849>
Can we make this private too?
- Kirk Lund
On April 3, 2017, 9:43 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58162/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 9:43 p.m.)
>
>
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * move ImportClusterConfigDistributedTest to open side
> * remove @Ignore from other two tests.
> * force the isGfshVM flag to be false before exeuting the command since class loading issue still contaminate the close
> side test environment.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 2d648bd599c57b91252aaf37bce4bf0635c4eda6
>
>
> Diff: https://reviews.apache.org/r/58162/diff/1/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 58162: GEM-1351: Move a test to the open side and
fix the other tests
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/#review171074
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On April 4, 2017, 10:02 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58162/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 10:02 p.m.)
>
>
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * move ImportClusterConfigDistributedTest to open side
> * remove @Ignore from other two tests.
> * force the isGfshVM flag to be false before exeuting the command since class loading issue still contaminate the close
> side test environment.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 6ae82da58923fdf3a44217c1773a40d8ff1001bc
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 2d648bd599c57b91252aaf37bce4bf0635c4eda6
>
>
> Diff: https://reviews.apache.org/r/58162/diff/2/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 58162: GEM-1351: Move a test to the open side and
fix the other tests
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/
-----------------------------------------------------------
(Updated April 4, 2017, 10:02 p.m.)
Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
* move ImportClusterConfigDistributedTest to open side
* remove @Ignore from other two tests.
* force the isGfshVM flag to be false before exeuting the command since class loading issue still contaminate the close
side test environment.
Diffs (updated)
-----
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 6ae82da58923fdf3a44217c1773a40d8ff1001bc
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 2d648bd599c57b91252aaf37bce4bf0635c4eda6
Diff: https://reviews.apache.org/r/58162/diff/2/
Changes: https://reviews.apache.org/r/58162/diff/1-2/
Testing
-------
precheckin running
Thanks,
Jinmei Liao