svn commit: r586472 - in /maven/archiva/trunk/archiva-base: archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/ archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/ ...

[jo...@apache.org]

Author: joakime
Date: Fri Oct 19 07:21:13 2007
New Revision: 586472

URL: http://svn.apache.org/viewvc?rev=586472&view=rev
Log:
Cleaning up potential multi-threading issues with use of static SimpleDateFormat.


Modified:
    maven/archiva/trunk/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/DaysOldRepositoryPurge.java
    maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/MetadataTools.java
    maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/scanner/RepositoryScanStatistics.java

Modified: maven/archiva/trunk/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/DaysOldRepositoryPurge.java
URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/DaysOldRepositoryPurge.java?rev=586472&r1=586471&r2=586472&view=diff
==============================================================================
--- maven/archiva/trunk/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/DaysOldRepositoryPurge.java (original)
+++ maven/archiva/trunk/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/maven/archiva/consumers/core/repository/DaysOldRepositoryPurge.java Fri Oct 19 07:21:13 2007
@@ -43,20 +43,17 @@
 public class DaysOldRepositoryPurge
     extends AbstractRepositoryPurge
 {
-    private static final SimpleDateFormat timestampParser;
-    static
-    {
-        timestampParser = new SimpleDateFormat( "yyyyMMdd.HHmmss" );
-        timestampParser.setTimeZone( DateUtils.UTC_TIME_ZONE );
-    }
+    private SimpleDateFormat timestampParser;
 
     private int daysOlder;
-
+    
     public DaysOldRepositoryPurge( ManagedRepositoryContent repository, ArtifactDAO artifactDao,
                                    int daysOlder )
     {
         super( repository, artifactDao );
         this.daysOlder = daysOlder;
+        timestampParser = new SimpleDateFormat( "yyyyMMdd.HHmmss" );
+        timestampParser.setTimeZone( DateUtils.UTC_TIME_ZONE );
     }
 
     public void process( String path )

Modified: maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/MetadataTools.java
URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/MetadataTools.java?rev=586472&r1=586471&r2=586472&view=diff
==============================================================================
--- maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/MetadataTools.java (original)
+++ maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/metadata/MetadataTools.java Fri Oct 19 07:21:13 2007
@@ -101,9 +101,9 @@
 
     private static final char NUMS[] = new char[] { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9' };
 
-    private static final SimpleDateFormat lastUpdatedFormat;
+    private SimpleDateFormat lastUpdatedFormat;
 
-    static
+    public MetadataTools()
     {
         lastUpdatedFormat = new SimpleDateFormat( "yyyyMMddHHmmss" );
         lastUpdatedFormat.setTimeZone( DateUtils.UTC_TIME_ZONE );

Modified: maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/scanner/RepositoryScanStatistics.java
URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/scanner/RepositoryScanStatistics.java?rev=586472&r1=586471&r2=586472&view=diff
==============================================================================
--- maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/scanner/RepositoryScanStatistics.java (original)
+++ maven/archiva/trunk/archiva-base/archiva-repository-layer/src/main/java/org/apache/maven/archiva/repository/scanner/RepositoryScanStatistics.java Fri Oct 19 07:21:13 2007
@@ -23,6 +23,7 @@
 import org.apache.maven.archiva.configuration.ManagedRepositoryConfiguration;
 import org.apache.maven.archiva.model.RepositoryContentStatistics;
 
+import java.text.SimpleDateFormat;
 import java.util.List;
 
 /**
@@ -39,6 +40,8 @@
     private transient List<String> invalidConsumers;
 
     private transient long startTimestamp;
+    
+    private SimpleDateFormat df = new SimpleDateFormat();
 
     public void triggerStart()
     {
@@ -76,7 +79,6 @@
 
     public String toDump( ManagedRepositoryConfiguration repo )
     {
-        java.text.SimpleDateFormat df = new java.text.SimpleDateFormat();
         StringBuffer buf = new StringBuffer();
 
         buf.append( "\n.\\ Scan of " ).append( this.getRepositoryId() );