[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1530: [CELEBORN-623] Ratis-shell add default rpc type

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1530:
URL: https://github.com/apache/incubator-celeborn/pull/1530#discussion_r1213870927


##########
bin/celeborn-ratis:
##########
@@ -71,6 +71,8 @@ function main {
   CELEBORN_RATIS_SHELL_JAVA_OPTS+=" -Dorg.apache.jasper.compiler.disablejsr199=true"
   CELEBORN_RATIS_SHELL_JAVA_OPTS+=" -Djava.net.preferIPv4Stack=true"
   CELEBORN_RATIS_SHELL_JAVA_OPTS+=" -Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false"
+  # Netty is supported by default
+  CELEBORN_RATIS_SHELL_JAVA_OPTS+=" -Draft.rpc.type=NETTY"

Review Comment:
   > some background:
   > 
   > * `netty` is chosen by coincidence, based on our research, `grpc` is selected by most of the projects that use ratis, maybe we need to investigate if we can switch to `grpc` at some time
   > * the ratis shell support changing rpc type by args
   
   According to the latest test, using `grpc` is runnable but with higher election time than netty. There are no clear benefits to using `grpc`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org