You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2011/12/06 01:39:40 UTC
[jira] [Created] (HADOOP-7884) test-patch seems to fail when a
patch goes across projects (common/hdfs/mapreduce) or touches
hadoop-assemblies/hadoop-dist.
test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
----------------------------------------------------------------------------------------------------------------------------
Key: HADOOP-7884
URL: https://issues.apache.org/jira/browse/HADOOP-7884
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 0.24.0
Reporter: Alejandro Abdelnur
Fix For: 0.24.0
Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7884) test-patch seems to fail when a
patch goes across projects (common/hdfs/mapreduce) or touches
hadoop-assemblies/hadoop-dist.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J resolved HADOOP-7884.
-----------------------------
Resolution: Not A Problem
Fix Version/s: (was: 0.24.0)
No longer a problem after HADOOP-8308.
> test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7884
> URL: https://issues.apache.org/jira/browse/HADOOP-7884
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
>
> Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7884) test-patch seems to fail when a
patch goes across projects (common/hdfs/mapreduce) or touches
hadoop-assemblies/hadoop-dist.
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167676#comment-13167676 ]
Tom White commented on HADOOP-7884:
-----------------------------------
The test-patch builds run with the base directory set to hadoop-{common,hdfs,mapreduce}-project. We could change common so it is run from the top-level, thus allowing cross-project patches, but it would mean that i) unit tests for every project are run for every change, and ii) only patches relative to the top-level would apply. i) is probably a good thing (changes to common should result in HDFS and MapReduce tests being run). For ii), do folks generally produce patches from the top-level anyway?
> test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7884
> URL: https://issues.apache.org/jira/browse/HADOOP-7884
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Fix For: 0.24.0
>
>
> Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7884) test-patch seems to fail when a
patch goes across projects (common/hdfs/mapreduce) or touches
hadoop-assemblies/hadoop-dist.
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167723#comment-13167723 ]
Alejandro Abdelnur commented on HADOOP-7884:
--------------------------------------------
My take is:
* all patches should be from top-level
* all patches should do a full build from top level (this ensures not API breaking)
* patches should run tests in the project of their changes (otherwise every test-patch would be too long)
* nighty builds should do a test run from trunk
> test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7884
> URL: https://issues.apache.org/jira/browse/HADOOP-7884
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Fix For: 0.24.0
>
>
> Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7884) test-patch seems to fail when a
patch goes across projects (common/hdfs/mapreduce) or touches
hadoop-assemblies/hadoop-dist.
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167773#comment-13167773 ]
Tom White commented on HADOOP-7884:
-----------------------------------
As things stand, test-patch will always do a build from the top-level to check that there are no breakages, but tests are run from hadoop-{common,hdfs,mapreduce}-project so only tests from the relevant project are run.
Re: nightly builds, there is one for each project that does a full test-run and build: https://builds.apache.org/job/Hadoop-Common-trunk/, https://builds.apache.org/job/Hadoop-Hdfs-trunk/, https://builds.apache.org/job/Hadoop-Mapreduce-trunk/. Perhaps we need a top-level one.
> test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7884
> URL: https://issues.apache.org/jira/browse/HADOOP-7884
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Fix For: 0.24.0
>
>
> Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira