You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "kanha-gupta (via GitHub)" <gi...@apache.org> on 2023/03/07 11:04:59 UTC
[GitHub] [shardingsphere] kanha-gupta opened a new pull request, #24490: support for Extract Function
kanha-gupta opened a new pull request, #24490:
URL: https://github.com/apache/shardingsphere/pull/24490
Fixes #24398
Added support for all possible Mysql queries for Extract function
(reference : MySQL documentation)
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #24490: support for Extract Function
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490#issuecomment-1459151716
@kanha-gupta Merged, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on pull request #24490: support for Extract Function
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490#issuecomment-1458226999
@RaigorJiang I don't know what could be a possible reason for E2E failure since all test are getting passed except one and I cant get any clue from logs
Can you please help ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #24490: support for Extract Function
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490#issuecomment-1458048126
> @RaigorJiang Hey, Antlr file can now parse all types of Extract function queries. Also do I have to add XML support for All possible EXTRACT queries too ? Right now I have optimised XML for SELECT EXTRACT(YEAR FROM '2019-07-02') query
Not necessary, just a representative use case is fine.
But now CI is failing, we need to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24490: support for Extract Function
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on pull request #24490: support for Extract Function
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490#issuecomment-1457978777
@RaigorJiang Hey, Antlr file can now parse all types of Extract function queries.
Also do I have to add XML support for All possible EXTRACT queries too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24490: support for Extract Function
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24490:
URL: https://github.com/apache/shardingsphere/pull/24490#issuecomment-1458098947
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24490?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24490](https://codecov.io/gh/apache/shardingsphere/pull/24490?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b09c4b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/134a24a80df9ef1ec959ea217db8cfd6a6f4cc2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (134a24a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3b09c4b differs from pull request most recent head 2668898. Consider uploading reports for the commit 2668898 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24490 +/- ##
=========================================
Coverage 50.22% 50.22%
Complexity 1588 1588
=========================================
Files 3270 3270
Lines 53705 53705
Branches 9884 9884
=========================================
Hits 26971 26971
Misses 24323 24323
Partials 2411 2411
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org