You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 18:14:57 UTC
[GitHub] [airflow] potiuk opened a new pull request #18020: Adds capability of Warnings for incompatible community providers
potiuk opened a new pull request #18020:
URL: https://github.com/apache/airflow/pull/18020
When we release providers, we do not know if some future version
of Airflow will be incompatible with them, so we cannot add hard
limits there. We have constraints that contain the "latest"
providers at the moment of release but if someone has an old
versions of providers installed and just upgrades Airflow, the
incompatible versions of providers might be still installed.
From now on Airflow will print warnings in case such incompatible
provider is detected.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18020: Adds capability of Warnings for incompatible community providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18020:
URL: https://github.com/apache/airflow/pull/18020#issuecomment-912723258
This one will fail until we merge #18018 is merged (it bumps celery to 2.1.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18020: Adds capability of Warnings for incompatible community providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18020:
URL: https://github.com/apache/airflow/pull/18020#issuecomment-912807759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18020: Adds capability of Warnings for incompatible community providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18020:
URL: https://github.com/apache/airflow/pull/18020#discussion_r702160378
##########
File path: airflow/providers_manager.py
##########
@@ -204,6 +205,11 @@ def wrapped_function(*args, **kwargs):
return provider_info_cache_decorator
+MIN_PROVIDER_VERSIONS = {
+ "apache-airflow-providers-celery": "2.1.0",
+}
Review comment:
Yep. Why not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18020: Adds capability of Warnings for incompatible community providers
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18020:
URL: https://github.com/apache/airflow/pull/18020#discussion_r702158295
##########
File path: airflow/providers_manager.py
##########
@@ -204,6 +205,11 @@ def wrapped_function(*args, **kwargs):
return provider_info_cache_decorator
+MIN_PROVIDER_VERSIONS = {
+ "apache-airflow-providers-celery": "2.1.0",
+}
Review comment:
Should we maybe put this higher up in the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18020: Adds capability of Warnings for incompatible community providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18020:
URL: https://github.com/apache/airflow/pull/18020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org