You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/11/08 17:28:30 UTC
[GitHub] [tomee] jeanouii opened a new pull request, #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
jeanouii opened a new pull request, #959:
URL: https://github.com/apache/tomee/pull/959
instead of requiring the interface to be implemented. Thanks Stefan Kalscheuer for reporting and for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] stklcode commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
stklcode commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308829472
I do not have write permissions on this repository, so I'm afraid I cannot do this.
What I can do is (re-)create this PR from my fork or you can cherry-pick the referenced commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308866109
Yes we can. It should work the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308868926
> Yes we can. It should work the same way
Ok. I will create a Jira for it, so we can pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308819736
I agree that it does not hurt. Can you push your changes in this branch so when I merge, your changes are included instead of me stealing your test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308861846
@jeanouii Do we want to backport this change to 8.x, too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii commented on pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308858672
You should be able to create a PR against this branch so I can merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii merged pull request #959: TOMEE-4065 Fix to allow @LoginToContinue to be used directly in the HttpAuthenticationMechanism
Posted by GitBox <gi...@apache.org>.
jeanouii merged PR #959:
URL: https://github.com/apache/tomee/pull/959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org