Re: [PR] feat: Support to customize broker podManagementPolicy from values.yaml [pulsar-helm-chart]

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari commented on code in PR #525:
URL: https://github.com/apache/pulsar-helm-chart/pull/525#discussion_r1741759920


##########
charts/pulsar/values.yaml:
##########
@@ -806,6 +806,7 @@ broker:
     maxReplicas: 3
     metrics: ~
     behavior: ~
+  podManagementPolicy: Parallel

Review Comment:
   simply provide the key without the value, so that it's absent by default.
   Please add a short documentation to the key. It's worth mentioning that the value cannot be modified without manual operations after a cluster has been deployed.



##########
charts/pulsar/templates/broker-statefulset.yaml:
##########
@@ -49,7 +49,7 @@ spec:
   podManagementPolicy: {{ $stsObj.spec.podManagementPolicy }}
   {{- else }}
   {{- if not .Values.components.functions }}
-  podManagementPolicy: Parallel
+  podManagementPolicy: {{ .Values.broker.podManagementPolicy }}
   {{- else }}
   podManagementPolicy: OrderedReady
   {{- end }}

Review Comment:
   I think that we'd need to take this existing logic into account. The default value in the values.yaml should be absent (nil). When the value is absent, the former logic should be used. If it's set, it would get applied.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org