[GitHub] [ozone] smengcl commented on a diff in pull request #3018: HDDS-6084. [Multi-Tenant] Handle upgrades to version supporting S3 multi-tenancy

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #3018:
URL: https://github.com/apache/ozone/pull/3018#discussion_r882961379


##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.1.0-1.2.0/callback.sh:
##########
@@ -64,8 +64,7 @@ with_old_version_downgraded() {
 
 with_new_version_finalized() {
   _check_hdds_mlvs 2
-  # OM currently only has one layout version.
-  _check_om_mlvs 0

Review Comment:
   You are right.
   
   Though in the latest feature branch it is indeed still 0 (probably fixed when I was resolving conflicts when doing the merge master 3 days ago):
   
   https://github.com/smengcl/hadoop-ozone/blob/HDDS-4944/hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.1.0-1.2.0/callback.sh#L47-L49
   
   Not sure why I bumped it when doing this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org