You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/04/10 01:34:02 UTC

Review Request 33041: [WinTP2] Error executing HDP setup task results in file not found

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33041/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk and Jayush Luniya.


Bugs: AMBARI-10422
    https://issues.apache.org/jira/browse/AMBARI-10422


Repository: ambari


Description
-------

Added missing parameter, which was invalidating the whole script


Diffs
-----

  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py db34c9fa09249ca766c7ec89f41f5ff54af76560 

Diff: https://reviews.apache.org/r/33041/diff/


Testing
-------

mvn clean install

set up a local VM cluster -> Tez service check ok


Thanks,

Florian Barca


Re: Review Request 33041: [WinTP2] Error executing HDP setup task results in file not found

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33041/#review79753
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On April 9, 2015, 11:34 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33041/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 11:34 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10422
>     https://issues.apache.org/jira/browse/AMBARI-10422
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added missing parameter, which was invalidating the whole script
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py db34c9fa09249ca766c7ec89f41f5ff54af76560 
> 
> Diff: https://reviews.apache.org/r/33041/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> set up a local VM cluster -> Tez service check ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 33041: [WinTP2] Error executing HDP setup task results in file not found

Posted by Florian Barca <fb...@hortonworks.com>.

> On April 10, 2015, 5:21 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py, line 28
> > <https://reviews.apache.org/r/33041/diff/1/?file=922034#file922034line28>
> >
> >     We can use HADOOP_NODE_INSTALL_ROOT instead?
> >     
> >     HADOOP_NODE=C:\hdp\
> >     HADOOP_NODE_INSTALL_ROOT=C:\hdp\

It's a pervasive practice in the whole HDP services code section. Doesn't look like something to be worth breaking the ranks upon.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33041/#review79703
-----------------------------------------------------------


On April 9, 2015, 11:34 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33041/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 11:34 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10422
>     https://issues.apache.org/jira/browse/AMBARI-10422
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added missing parameter, which was invalidating the whole script
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py db34c9fa09249ca766c7ec89f41f5ff54af76560 
> 
> Diff: https://reviews.apache.org/r/33041/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> set up a local VM cluster -> Tez service check ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 33041: [WinTP2] Error executing HDP setup task results in file not found

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33041/#review79703
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py
<https://reviews.apache.org/r/33041/#comment129229>

    We can use HADOOP_NODE_INSTALL_ROOT instead?
    
    HADOOP_NODE=C:\hdp\
    HADOOP_NODE_INSTALL_ROOT=C:\hdp\


- Jayush Luniya


On April 9, 2015, 11:34 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33041/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 11:34 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10422
>     https://issues.apache.org/jira/browse/AMBARI-10422
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added missing parameter, which was invalidating the whole script
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py db34c9fa09249ca766c7ec89f41f5ff54af76560 
> 
> Diff: https://reviews.apache.org/r/33041/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> set up a local VM cluster -> Tez service check ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>