You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/05/03 21:38:42 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #620: Multiple updates to launch wizard
Shanedell opened a new pull request, #620:
URL: https://github.com/apache/daffodil-vscode/pull/620
Multiple updates to launch wizard:
- Add missing config keys and values to parsed configs.
- If not done this causes the launch wizard to not open.
- Fix a issue with some TDML settings not showing up properly.
- Update TDML config settings styling to better match the rest of the launch wizard.
- When these items are hidden, the height and width are set to 0 so no large black space would be created in the UI.
- Add support for setting data editor settings. These were omegaEditPort, logFile and logLevel.
- Don't show TDML name field when action is set to "none".
Closes #617
Closes #619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184947218
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
Sometimes you want a failsafe (e.g., PID files to help recover from an unexpected crash), and other times you want to _reveal_ programming errors (e.g., asserts). In this case, I'd prefer the latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184455027
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
It is, this way is just a fail safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188535399
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
Review Comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1190113877
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
Review Comment:
I just renamed the package.json settings. So that in TS code you still know its a dataEditorConfig not the actual dataEditor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184453248
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
Shouldn't something _always_ be specified for a default server port (debug, data, or otherwise) in `package.json`? If not, that's a bug in my opinion and the code should error out indicating that no default value was specified in `package.json` when it should have been.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188892239
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
Review Comment:
@arosien Should this be changed everywhere `dataEditorConfig` is used or just inside of package.json? Meaning like the interface that was created, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188123845
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
Review Comment:
```suggestion
"dataEditor": {
```
`Config` seems redundant.
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
+ "type": "object",
+ "description": "Configuration for Data Editor. Settings are omegaEditPort, logFile and logLevel",
+ "default": {
+ "omegaEditPort": 9000,
Review Comment:
```suggestion
"port": 9000,
```
Maybe just `port`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
I'm unsure what the schema definitions in this `configuration` section are for. They aren't official sections listed under https://code.visualstudio.com/api/extension-guides/debugger-extension#anatomy-of-the-package.json-of-a-debugger-extension.
Looking around, it seems to be a custom configuration section we use to provide default values(?). If so, it can probably be removed and the `contributes/debuggers/configurationAttributes` section can be the sole location of launch schema and defaults.
This should probably be a different ticket for a different release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184952758
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
I can see where you are coming from. But I believe maybe we should ask others for their input as well before deciding what to change to and do from now on. @stevedlawrence @mbeckerle @rt320 @arosien @stricklandrbls @michael-hoke @NolanMatt @nlewis05 what are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184448604
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
"type": "integer",
"description": "Editor server default port",
"default": 9000
},
- "dataEditor.logFile": {
+ "dataEditorLogFile": {
"type": "string",
"description": "Path to log file for data editor",
"default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
},
- "dataEditor.logLevel": {
+ "dataEditorLogLevel": {
Review Comment:
Should this just be `logLevel`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
"type": "integer",
"description": "Editor server default port",
"default": 9000
},
- "dataEditor.logFile": {
+ "dataEditorLogFile": {
Review Comment:
Should this just be `logFile`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
Should this just be `omegaEditPort`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184453248
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
Shouldn't something _always_ be specified for a default server port (debug, data, or otherwise) in `package.json`. If not, that's a bug in my opinion and the code should error out indicating that no default value was specified in `package.json` when it should have been.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#issuecomment-1540055637
@arosien, what do you think about +1ing _provided_ your suggestions are implemented as stated. @Shanedell can usually implement the suggestions within a day, but then waiting for 2 +1's can take _days_ and these fixes are blocking the RC2 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188895758
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
Yeah this what it is for. However, it was separated from `configurationAttributes` as we were using it for defaults and making sure the type is right initially. I don't think we want to move them into `configurationAttributes`, doing this allows the user to change their values, but they are only there for initial values of object attributes. I think we actually wouldn't want the user to have the ability to set these item, at least some of them since it really wouldn't do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184966125
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
I don't think I have a strong opinion one way or the other in general--there's good arguments for both sides. It's probably easier to detect typos or configuration name changes if you don't do defaults, so I'd maybe lean towards no default.
That said, in this particular case it looks like all uses of `defaultConf.get(...)` provide a default value, so at least in this PR I suggest we stay consistent with that and provide a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#issuecomment-1536209371
@Shanedell, make sure to also document the changes here https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil™-Extension-for-Visual-Studio-Code:-v1.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188535025
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
+ "type": "object",
+ "description": "Configuration for Data Editor. Settings are omegaEditPort, logFile and logLevel",
+ "default": {
+ "omegaEditPort": 9000,
Review Comment:
Since it's namespaced, I think just `port` is a fine choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Multiple updates to launch wizard
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184352159
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
That is what this trying to do. The second value is the default value if nothing is found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Multiple updates to launch wizard
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184348452
##########
src/utils.ts:
##########
@@ -147,6 +150,15 @@ export function getConfig(
daffodilDebugClasspath: daffodilDebugClasspath
? daffodilDebugClasspath
: defaultConf.get('daffodilDebugClasspath', ''),
+ dataEditorOmegaEditPort: dataEditorOmegaEditPort
+ ? dataEditorOmegaEditPort
+ : defaultConf.get('dataEditor.omegaEditPort', 9000),
Review Comment:
Can't we pull the default port from package.json?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184450086
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
I believe they should all keep `dataEditor` so we are aware of what they are for. These ones are used for getting default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org