[GitHub] [pinot] xiangfu0 commented on pull request #7775: Include commons-lang3

[GitBox <gi...@apache.org>]

xiangfu0 commented on pull request #7775:
URL: https://github.com/apache/pinot/pull/7775#issuecomment-984227391


   no idea, it should be compile dependency.
   
   On Wed, Dec 1, 2021 at 17:23 Xiaotian (Jackie) Jiang <
   ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In pinot-clients/pom.xml
   > <https://github.com/apache/pinot/pull/7775#discussion_r760693989>:
   >
   > > +    <dependency>
   > +      <groupId>org.apache.commons</groupId>
   > +      <artifactId>commons-lang3</artifactId>
   > +    </dependency>
   >
   > commons-lang3 is already included in the pinot-spi. I think the issue is
   > that pinot-spi is added as provided. @xiangfu0
   > <https://github.com/xiangfu0> Any idea why we add pinot-spi as provided
   > here?
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/pinot/pull/7775#discussion_r760693989>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJFPSB7DPGKGWZ335AIMWLUO3C7XANCNFSM5ID2IACQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org