You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/05/03 04:05:10 UTC
Review Request 70588: ATLAS-3188: Regression: Simple insert queries
are being captured in ATLAS_HOOK topic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-3188
https://issues.apache.org/jira/browse/ATLAS-3188
Repository: atlas
Description
-------
insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
Inserting 100 rows in a table is generating 100 messages in the kafka topic.
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
Diff: https://reviews.apache.org/r/70588/diff/1/
Testing
-------
validated that "insert into values" query doesn't create hive_process entities
Thanks,
Sarath Subramanian
Re: Review Request 70588: ATLAS-3188: Regression: Simple insert
queries are being captured in ATLAS_HOOK topic
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/#review215026
-----------------------------------------------------------
Can you please add unit test?
- Ashutosh Mestry
On May 3, 2019, 4:36 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70588/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 4:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3188
> https://issues.apache.org/jira/browse/ATLAS-3188
>
>
> Repository: atlas
>
>
> Description
> -------
>
> insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
>
> Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
>
> Inserting 100 rows in a table is generating 100 messages in the kafka topic.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
>
>
> Diff: https://reviews.apache.org/r/70588/diff/2/
>
>
> Testing
> -------
>
> validated that "insert into values" query doesn't create hive_process entities
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70588: ATLAS-3188: Regression: Simple insert
queries are being captured in ATLAS_HOOK topic
Posted by Sridhar K <Sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/#review215045
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
Lines 122 (patched)
<https://reviews.apache.org/r/70588/#comment301424>
Why do we need this check...just assign the value.
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
Lines 128 (patched)
<https://reviews.apache.org/r/70588/#comment301425>
same here.
- Sridhar K
On May 3, 2019, 4:36 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70588/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 4:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3188
> https://issues.apache.org/jira/browse/ATLAS-3188
>
>
> Repository: atlas
>
>
> Description
> -------
>
> insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
>
> Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
>
> Inserting 100 rows in a table is generating 100 messages in the kafka topic.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
>
>
> Diff: https://reviews.apache.org/r/70588/diff/2/
>
>
> Testing
> -------
>
> validated that "insert into values" query doesn't create hive_process entities
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70588: ATLAS-3188: Regression: Simple insert
queries are being captured in ATLAS_HOOK topic
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/#review215012
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 3, 2019, 4:36 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70588/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 4:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3188
> https://issues.apache.org/jira/browse/ATLAS-3188
>
>
> Repository: atlas
>
>
> Description
> -------
>
> insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
>
> Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
>
> Inserting 100 rows in a table is generating 100 messages in the kafka topic.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
>
>
> Diff: https://reviews.apache.org/r/70588/diff/2/
>
>
> Testing
> -------
>
> validated that "insert into values" query doesn't create hive_process entities
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70588: ATLAS-3188: Regression: Simple insert
queries are being captured in ATLAS_HOOK topic
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/
-----------------------------------------------------------
(Updated May 2, 2019, 9:36 p.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-3188
https://issues.apache.org/jira/browse/ATLAS-3188
Repository: atlas
Description
-------
insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
Inserting 100 rows in a table is generating 100 messages in the kafka topic.
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
Diff: https://reviews.apache.org/r/70588/diff/2/
Changes: https://reviews.apache.org/r/70588/diff/1-2/
Testing
-------
validated that "insert into values" query doesn't create hive_process entities
Thanks,
Sarath Subramanian
Re: Review Request 70588: ATLAS-3188: Regression: Simple insert
queries are being captured in ATLAS_HOOK topic
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70588/#review215011
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 3, 2019, 4:05 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70588/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 4:05 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3188
> https://issues.apache.org/jira/browse/ATLAS-3188
>
>
> Repository: atlas
>
>
> Description
> -------
>
> insert into <table> values (<values>) is triggering messages in ATLAS_HOOK topic. Due to this, Atlas is reporting the operations in Audits.
>
> Ideally, insert queries should not generate any messages in ATLAS_HOOK since they do not play any role in lineage
>
> Inserting 100 rows in a table is generating 100 messages in the kafka topic.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 54cd48f04
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java f378d8457
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java cdb4cd218
>
>
> Diff: https://reviews.apache.org/r/70588/diff/1/
>
>
> Testing
> -------
>
> validated that "insert into values" query doesn't create hive_process entities
>
>
> Thanks,
>
> Sarath Subramanian
>
>