You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/11/10 01:28:29 UTC
[GitHub] cordova-ios pull request #275: CB-12127 - Add buildFlag support in build.jso...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/275
CB-12127 - Add buildFlag support in build.json
### Platforms affected
iOS
### What does this PR do?
Add build.json support for the "buildFlag" key. The value for the key can be an array or a string. Analogous to the "buildFlag" command line option.
### What testing has been done on this change?
Manual testing.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 3a67515a4cba5af11f2069d957cd2b0fbc6d8823
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-11-10T01:21:35Z
CB-12127 - Add buildFlag support in build.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #275: CB-12127 - Add buildFlag support in build.jso...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #275: CB-12127 - Add buildFlag support in build.json
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/275
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/275?src=pr) is 60.00% (diff: 0.00%)
> Merging [#275](https://codecov.io/gh/apache/cordova-ios/pull/275?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #275 diff @@
==========================================
Files 12 12
Lines 1325 1325
Methods 202 202
Messages 0 0
Branches 224 224
==========================================
Hits 795 795
Misses 530 530
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [50a185a...3a67515](https://codecov.io/gh/apache/cordova-ios/compare/50a185a6ec9e1b231cf0cddaddb6f74101c93f38...3a67515a4cba5af11f2069d957cd2b0fbc6d8823?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org