You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/09 19:12:49 UTC

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #5757: [Relay] Fix for recursive let

icemelon9 opened a new pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757


   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   
   cc @jroesch @kevinthesun 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757#issuecomment-641666367


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] lixiaoquan commented on pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
lixiaoquan commented on pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757#issuecomment-641943041


   Is it possbile to happen in other passes? I run into a stack overflow in WellFormChecker, and it keeps visiting LetNode. Not sure whether it is the same issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] kevinthesun commented on pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
kevinthesun commented on pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757#issuecomment-642389407


   Thanks @icemelon9 @jroesch @lixiaoquan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] kevinthesun merged pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
kevinthesun merged pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
icemelon9 commented on pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757#issuecomment-642335433


   @lixiaoquan Yes, that's possible. I could take a look as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on pull request #5757: [Relay] Fix for recursive let

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #5757:
URL: https://github.com/apache/incubator-tvm/pull/5757#issuecomment-641666481


   ha actually I think I wrote this code on our branch, was thinking this looked familiar 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org