You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Schadix <gi...@git.apache.org> on 2015/12/21 19:42:19 UTC
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
GitHub user Schadix opened a pull request:
https://github.com/apache/spark/pull/10416
[SPARK-12453] [Streaming] Spark Streaming Kinesis Example broken due …
…to wrong AWS Java SDK version
Fix successfully tested by me.
Maybe the tests have to be improved as they passed the previous version as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Schadix/spark fix-aws-java-sdk-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10416
----
commit d6eaf460ac549544c90d97a1ed87682d83906eb7
Author: Martin Schade <sc...@gmail.com>
Date: 2015-12-21T18:33:54Z
[SPARK-12453] [Streaming] Spark Streaming Kinesis Example broken due to wrong AWS Java SDK version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by Schadix <gi...@git.apache.org>.
Github user Schadix closed the pull request at:
https://github.com/apache/spark/pull/10416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-167091135
Go ahead and try the change discussed in the JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-166429971
This isn't vs master, and is a duplicate. Please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by BrianLondon <gi...@git.apache.org>.
Github user BrianLondon commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-167480524
@srowen I can't close this because I didn't open it, but there's an explicit dependency removal PR at #10492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by Schadix <gi...@git.apache.org>.
Github user Schadix commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-167631293
No problem. Who creates the one against master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by BrianLondon <gi...@git.apache.org>.
Github user BrianLondon commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-166984326
This change worked for me on an AWS hosted Kinesis stream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-167509793
Roger that, @Schadix would you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12453] [Streaming] Spark Streaming Kine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-166387366
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org